You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by wilderrodrigues <gi...@git.apache.org> on 2015/07/16 12:50:30 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-8641 - When calling "update ho...

GitHub user wilderrodrigues opened a pull request:

    https://github.com/apache/cloudstack/pull/596

    CLOUDSTACK-8641 - When calling "update hostpassword" API it throws NP…

    …E if the update_passwd_on_host if not informed
    
       - On getUpdatePasswdOnHost() method, if updatePasswdOnHost is null then return false.
    
    Apologies for the NPE. This will fix it.
    
    Output of command updating KVM host DB only:
    
    (local) 🐵 > update hostpassword hostid=9ae1d93b-d09c-4e1c-94fa-9082e81cca26 username=root password=admin123
    success = true
    
    @DaanHoogland @bhaisaab that's a quick one to review. :)
    
    Cheers,
    Wilder

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/schubergphilis/cloudstack fix/CLOUDSTACK-8641

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #596
    
----
commit 5ecf24919fa6fb935578287587844d5463b9e76b
Author: wilderrodrigues <wr...@schubergphilis.com>
Date:   2015-07-16T10:13:27Z

    CLOUDSTACK-8641 - When calling "update hostpassword" API it throws NPE if the update_passwd_on_host if not informed
    
       - On getUpdatePasswdOnHost() method, if updatePasswdOnHost is null then return false.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8641 - When calling "update ho...

Posted by bhaisaab <gi...@git.apache.org>.

Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/596#issuecomment-121949123
  
    LGTM, merging 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8641 - When calling "update ho...

Posted by DaanHoogland <gi...@git.apache.org>.

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/596#issuecomment-121932811
  
    ltgm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8641 - When calling "update ho...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/596


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---