You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/26 13:39:58 UTC

[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3555: ARTEMIS-2716 Implements pluggable Quorum Vote

franz1981 edited a comment on pull request #3555:
URL: https://github.com/apache/activemq-artemis/pull/3555#issuecomment-848778443


   I see that https://issues.apache.org/jira/browse/ARTEMIS-2297 can cause `ReplicationManager::sendSynchronizationDone` to behave differently with the pluggable quorum vote: 
   the original JIRA was meant to force an isolated `live` to suicide to save split brain to happen; while the new quorum this is not needed because network isolation is already handled by the distributed lock listener, that should force the broker to suicide.
   I probably need to modify `ReplicationManager` to ignore the quorum members count or just save `QuorumManager` to be created.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org