You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/20 08:32:42 UTC

[GitHub] [rocketmq] liyiwen3 opened a new issue #1732: There are obvious problems in "commitOffset" that is a method in ConsumerOffsetManager.class

liyiwen3 opened a new issue #1732: There are obvious problems in "commitOffset" that is a method in ConsumerOffsetManager.class
URL: https://github.com/apache/rocketmq/issues/1732
 
 
   the code :
   `
   private void commitOffset(final String clientHost, final String key, final int queueId, final long offset) {
           ConcurrentMap<Integer, Long> map = this.offsetTable.get(key);
           if (null == map) {
               map = new ConcurrentHashMap<Integer, Long>(32);
               map.put(queueId, offset);
               this.offsetTable.put(key, map);
           } else {
               Long storeOffset = map.put(queueId, offset);
               if (storeOffset != null && offset < storeOffset) {
                   log.warn("[NOTIFYME]update consumer offset less than store. clientHost={}, key={}, queueId={}, requestOffset={}, storeOffset={}", clientHost, key, queueId, offset, storeOffset);
               }
           }
       }
   `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] vongosling closed issue #1732: There are obvious problems in "commitOffset" that is a method in ConsumerOffsetManager.class

Posted by GitBox <gi...@apache.org>.
vongosling closed issue #1732: There are obvious problems in "commitOffset" that is a method in ConsumerOffsetManager.class
URL: https://github.com/apache/rocketmq/issues/1732
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] vongosling commented on issue #1732: There are obvious problems in "commitOffset" that is a method in ConsumerOffsetManager.class

Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #1732: There are obvious problems in "commitOffset" that is a method in ConsumerOffsetManager.class
URL: https://github.com/apache/rocketmq/issues/1732#issuecomment-576188311
 
 
   Could you kindly elaborate on the question, preferably a test statement? I will first close the similar questions you submitted. If you can describe the questions in more detail, I believe many guys in the community willing to reply and make improvement:-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services