You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by "liubao68 (via GitHub)" <gi...@apache.org> on 2023/09/01 06:52:10 UTC

[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request, #3933: [SCB-2808]DiscoveryTree changed to bean and not handler all services

liubao68 opened a new pull request, #3933:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3933

   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3933: [SCB-2808]DiscoveryTree changed to bean and not handler all services

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3933:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3933#issuecomment-1702280271

   ## [Codecov](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3933?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#3933](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3933?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (960e891) into [master](https://app.codecov.io/gh/apache/servicecomb-java-chassis/commit/77279e025e3f96122571d9b471404e6913b4b0bf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (77279e0) will **decrease** coverage by `0.03%`.
   > Report is 3 commits behind head on master.
   > The diff coverage is `53.84%`.
   
   > :exclamation: Current head 960e891 differs from pull request most recent head 6674d1d. Consider uploading reports for the commit 6674d1d to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3933      +/-   ##
   ============================================
   - Coverage     42.80%   42.77%   -0.03%     
   + Complexity     5270     5264       -6     
   ============================================
     Files          1416     1416              
     Lines         34749    34749              
     Branches       3373     3373              
   ============================================
   - Hits          14873    14863      -10     
   - Misses        18678    18684       +6     
   - Partials       1198     1202       +4     
   ```
   
   
   | [Files Changed](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3933?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `72.88% <53.84%> (-3.39%)` | :arrow_down: |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/servicecomb-java-chassis/pull/3933/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3933: [SCB-2808]DiscoveryTree changed to bean and not handler all services

Posted by "liubao68 (via GitHub)" <gi...@apache.org>.
liubao68 merged PR #3933:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3933


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org