You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2016/06/30 14:27:10 UTC
[jira] [Comment Edited] (HADOOP-11601) Enhance FS spec & tests to
mandate FileStatus.getBlocksize() >0 for non-empty files
[ https://issues.apache.org/jira/browse/HADOOP-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357141#comment-15357141 ]
Allen Wittenauer edited comment on HADOOP-11601 at 6/30/16 2:26 PM:
--------------------------------------------------------------------
Yetus is working exactly as it is supposed to. You can even test this yourself:
{code}
$ dev-support/bin/smart-apply-patch HADOOP-11601
Processing: HADOOP-11601
HADOOP-11601 appears to be a Github PR. Switching Modes.
GITHUB PR #50 is being downloaded at Thu Jun 30 07:09:27 PDT 2016 from
https://github.com/apache/hadoop/pull/50
Patch from GITHUB PR #50 is being downloaded at Thu Jun 30 07:09:28 PDT 2016 from
https://github.com/apache/hadoop/pull/50.patch
ERROR: Aborting! HADOOP-11601 cannot be verified.
$ wget https://github.com/apache/hadoop/pull/50.patch
--2016-06-30 07:09:36-- https://github.com/apache/hadoop/pull/50.patch
Resolving github.com... 192.30.253.113
Connecting to github.com|192.30.253.113|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://patch-diff.githubusercontent.com/raw/apache/hadoop/pull/50.patch [following]
--2016-06-30 07:09:36-- https://patch-diff.githubusercontent.com/raw/apache/hadoop/pull/50.patch
Resolving patch-diff.githubusercontent.com... 192.30.253.113
Connecting to patch-diff.githubusercontent.com|192.30.253.113|:443... connected.
HTTP request sent, awaiting response... 200 OK
Cookie coming from patch-diff.githubusercontent.com attempted to set domain to github.com
Length: unspecified [text/plain]
Saving to: '50.patch'
50.patch [ <=> ] 11.11K 38.5KB/s in 0.3s
2016-06-30 07:09:37 (38.5 KB/s) - '50.patch' saved [11377]
$ git apply 50.patch
50.patch:149: trailing whitespace.
50.patch:175: trailing whitespace.
50.patch:181: trailing whitespace.
try(
50.patch:213: trailing whitespace.
50.patch:219: trailing whitespace.
error: patch failed: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractCreateTest.java:163
error: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractCreateTest.java: patch does not apply
error: patch failed: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java:23
error: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java: patch does not apply
{code}
Again: you've switched from github to patch attach and Yetus is programmed such that once you go github, you need to do a lot of surgery on the JIRA issue to switch back.
was (Author: aw):
{code}
$ dev-support/bin/smart-apply-patch HADOOP-11601
Processing: HADOOP-11601
HADOOP-11601 appears to be a Github PR. Switching Modes.
GITHUB PR #50 is being downloaded at Thu Jun 30 07:09:27 PDT 2016 from
https://github.com/apache/hadoop/pull/50
Patch from GITHUB PR #50 is being downloaded at Thu Jun 30 07:09:28 PDT 2016 from
https://github.com/apache/hadoop/pull/50.patch
ERROR: Aborting! HADOOP-11601 cannot be verified.
$ wget https://github.com/apache/hadoop/pull/50.patch
--2016-06-30 07:09:36-- https://github.com/apache/hadoop/pull/50.patch
Resolving github.com... 192.30.253.113
Connecting to github.com|192.30.253.113|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://patch-diff.githubusercontent.com/raw/apache/hadoop/pull/50.patch [following]
--2016-06-30 07:09:36-- https://patch-diff.githubusercontent.com/raw/apache/hadoop/pull/50.patch
Resolving patch-diff.githubusercontent.com... 192.30.253.113
Connecting to patch-diff.githubusercontent.com|192.30.253.113|:443... connected.
HTTP request sent, awaiting response... 200 OK
Cookie coming from patch-diff.githubusercontent.com attempted to set domain to github.com
Length: unspecified [text/plain]
Saving to: '50.patch'
50.patch [ <=> ] 11.11K 38.5KB/s in 0.3s
2016-06-30 07:09:37 (38.5 KB/s) - '50.patch' saved [11377]
$ git apply 50.patch
50.patch:149: trailing whitespace.
50.patch:175: trailing whitespace.
50.patch:181: trailing whitespace.
try(
50.patch:213: trailing whitespace.
50.patch:219: trailing whitespace.
error: patch failed: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractCreateTest.java:163
error: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractCreateTest.java: patch does not apply
error: patch failed: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java:23
error: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/ContractTestUtils.java: patch does not apply
{code}
> Enhance FS spec & tests to mandate FileStatus.getBlocksize() >0 for non-empty files
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-11601
> URL: https://issues.apache.org/jira/browse/HADOOP-11601
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs, test
> Affects Versions: 2.6.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-11601-001.patch, HADOOP-11601-002.patch, HADOOP-11601-003.patch, HADOOP-11601-004.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> HADOOP-11584 has shown that the contract tests are not validating that {{FileStatus.getBlocksize()}} must be >0 for any analytics jobs to partition workload correctly.
> Clarify in text and add test to do this. Test MUST be designed to work against eventually consistent filesystems where {{getFileStatus()}} may not be immediately visible, by retrying operation if FS declares it is an object store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org