[GitHub] [solr] epugh commented on pull request #1880: SOLR-16956: fix not being able to stop a solr by port number

["epugh (via GitHub)" <gi...@apache.org>]

epugh commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1703815652

   Thanks @cpoerschke  for the feedback...  one thing I noticed in the BATS docs is that it suggests running shellcheck.   That isn't actually something I've ever done, and I wonder if it's the type of thing that should be run as part of precommit to make sure we keep both our bin/solr script and the various bats tests following best practices?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org