You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/10/27 03:45:22 UTC
[incubator-superset] branch master updated: feat(explore): update
the order of datasource dropdown menu (#11424)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new fd8f4e9 feat(explore): update the order of datasource dropdown menu (#11424)
fd8f4e9 is described below
commit fd8f4e92157d46661b74d0b5a891bcc08d566b7b
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Mon Oct 26 20:44:44 2020 -0700
feat(explore): update the order of datasource dropdown menu (#11424)
---
.../src/explore/components/controls/DatasourceControl.jsx | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/src/explore/components/controls/DatasourceControl.jsx b/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
index 709a927..1d70249 100644
--- a/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
+++ b/superset-frontend/src/explore/components/controls/DatasourceControl.jsx
@@ -194,6 +194,11 @@ class DatasourceControl extends React.PureComponent {
const datasourceMenu = (
<Menu onClick={this.handleMenuItemClick}>
+ {this.props.isEditable && (
+ <Menu.Item key={EDIT_DATASET} data-test="edit-dataset">
+ {t('Edit Dataset')}
+ </Menu.Item>
+ )}
<Menu.Item key={CHANGE_DATASET}>{t('Change Dataset')}</Menu.Item>
<Menu.Item key={EXPLORE_IN_SQL_LAB}>
<a
@@ -201,14 +206,9 @@ class DatasourceControl extends React.PureComponent {
target="_blank"
rel="noopener noreferrer"
>
- {t('Explore in SQL Lab')}
+ {t('View in SQL Lab')}
</a>
</Menu.Item>
- {this.props.isEditable && (
- <Menu.Item key={EDIT_DATASET} data-test="edit-dataset">
- {t('Edit Dataset')}
- </Menu.Item>
- )}
</Menu>
);