[GitHub] janpio commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta…

[GitBox <gi...@apache.org>]

janpio commented on a change in pull request #99: Make transparency of statusbar persistent when hiding and showing sta…
URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#discussion_r203352364
 
 

 ##########
 File path: src/android/StatusBar.java
 ##########
 @@ -227,20 +236,22 @@ private void setStatusBarBackgroundColor(final String colorPref) {
     }
 
     private void setStatusBarTransparent(final boolean transparent) {
-        if (Build.VERSION.SDK_INT >= 21) {
+        this.transparent = transparent;
             final Window window = cordova.getActivity().getWindow();
             if (transparent) {
                 window.getDecorView().setSystemUiVisibility(
                         View.SYSTEM_UI_FLAG_LAYOUT_STABLE
                                 | View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);
-                window.setStatusBarColor(Color.TRANSPARENT);
+
+                if (Build.VERSION.SDK_INT >= 21) {
 
 Review comment:
   Why did this SDK version check get moved inside here? 
   Does the other stuff also work on earlier versions?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org