[GitHub] [cassandra] adelapena commented on a diff in pull request #1643: Cassandra 17232 4.0

[GitBox <gi...@apache.org>]

adelapena commented on code in PR #1643:
URL: https://github.com/apache/cassandra/pull/1643#discussion_r881558920


##########
test/unit/org/apache/cassandra/db/commitlog/CommitLogTest.java:
##########
@@ -118,6 +119,8 @@ public static Collection<Object[]> generateData()
 
     public static void beforeClass() throws ConfigurationException
     {
+        KEYSPACE1 = "CommitLogTest" + ksIter;
+        KEYSPACE2 = "CommitLogTestNonDurable" + ksIter++;

Review Comment:
   This {{beforeClass}} static method is run only once at the beginning of the suite, so the keyspace name suffix is always zero, even across different sets of parameters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org