You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2013/01/06 11:13:25 UTC

Review Request: FLUME-1516. Use dual checkpoints in File Channel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8847/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Added support for backing up the checkpoint and recover from that.


This addresses bug FLUME-1516.
    https://issues.apache.org/jira/browse/FLUME-1516


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java a19bdb4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 186b15a 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java 451a9d4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 24368b3 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java 74a2bc8 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 7094d3c 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 3da09ab 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb 

Diff: https://reviews.apache.org/r/8847/diff/


Testing
-------

Added unit tests to test the new feature. All current unit tests pass.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1516. Use dual checkpoints in File Channel

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8847/
-----------------------------------------------------------

(Updated Jan. 8, 2013, 10:30 p.m.)


Review request for Flume.


Changes
-------

Update tests to be a bit cleaner


Description
-------

Added support for backing up the checkpoint and recover from that.


This addresses bug FLUME-1516.
    https://issues.apache.org/jira/browse/FLUME-1516


Diffs (updated)
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java b136eb0 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java a19bdb4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 7f35301 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java 451a9d4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 24368b3 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java 0f9456b 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 7094d3c 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 3da09ab 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb 

Diff: https://reviews.apache.org/r/8847/diff/


Testing
-------

Added unit tests to test the new feature. All current unit tests pass.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1516. Use dual checkpoints in File Channel

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8847/
-----------------------------------------------------------

(Updated Jan. 8, 2013, 7:23 p.m.)


Review request for Flume.


Changes
-------

Rebased on trunk.


Description
-------

Added support for backing up the checkpoint and recover from that.


This addresses bug FLUME-1516.
    https://issues.apache.org/jira/browse/FLUME-1516


Diffs (updated)
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java b136eb0 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java a19bdb4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 7f35301 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java 451a9d4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 24368b3 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java 0f9456b 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 7094d3c 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 3da09ab 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb 

Diff: https://reviews.apache.org/r/8847/diff/


Testing
-------

Added unit tests to test the new feature. All current unit tests pass.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1516. Use dual checkpoints in File Channel

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8847/
-----------------------------------------------------------

(Updated Jan. 7, 2013, 12:43 a.m.)


Review request for Flume.


Changes
-------

Test updates and check if backup was completed before attempting to restore. If none exists, then continue with what we do currently.


Description
-------

Added support for backing up the checkpoint and recover from that.


This addresses bug FLUME-1516.
    https://issues.apache.org/jira/browse/FLUME-1516


Diffs (updated)
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java 13b50da 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java a19bdb4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 186b15a 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java 451a9d4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 24368b3 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java 74a2bc8 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 7094d3c 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 3da09ab 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb 

Diff: https://reviews.apache.org/r/8847/diff/


Testing
-------

Added unit tests to test the new feature. All current unit tests pass.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1516. Use dual checkpoints in File Channel

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8847/
-----------------------------------------------------------

(Updated Jan. 7, 2013, 12:31 a.m.)


Review request for Flume.


Description
-------

Added support for backing up the checkpoint and recover from that.


This addresses bug FLUME-1516.
    https://issues.apache.org/jira/browse/FLUME-1516


Diffs
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java 13b50da 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java a19bdb4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 186b15a 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java 451a9d4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 24368b3 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java 74a2bc8 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 7094d3c 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 3da09ab 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb 

Diff: https://reviews.apache.org/r/8847/diff/


Testing
-------

Added unit tests to test the new feature. All current unit tests pass.


Thanks,

Hari Shreedharan


Re: Review Request: FLUME-1516. Use dual checkpoints in File Channel

Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8847/
-----------------------------------------------------------

(Updated Jan. 6, 2013, 10:19 p.m.)


Review request for Flume.


Changes
-------

If backup does not exist, use the old method and don't restore anything.


Description
-------

Added support for backing up the checkpoint and recover from that.


This addresses bug FLUME-1516.
    https://issues.apache.org/jira/browse/FLUME-1516


Diffs (updated)
-----

  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStore.java 13b50da 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFactory.java a19bdb4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFile.java 186b15a 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/EventQueueBackingStoreFileV3.java 451a9d4 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java d921387 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannelConfiguration.java 24368b3 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java 74a2bc8 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java 8a4201c 
  flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Serialization.java 7094d3c 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelBase.java 3da09ab 
  flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java ea57cdb 

Diff: https://reviews.apache.org/r/8847/diff/


Testing
-------

Added unit tests to test the new feature. All current unit tests pass.


Thanks,

Hari Shreedharan