[GitHub] [cassandra] jasonstack commented on a change in pull request #535: Cassandra 15229 trunk

[GitBox <gi...@apache.org>]

jasonstack commented on a change in pull request #535:
URL: https://github.com/apache/cassandra/pull/535#discussion_r499155845



##########
File path: src/java/org/apache/cassandra/metrics/BufferPoolMetrics.java
##########
@@ -25,24 +25,47 @@
 
 public class BufferPoolMetrics
 {
-    private static final MetricNameFactory factory = new DefaultNameFactory("BufferPool");
+    /** Total number of hits */
+    public final Meter hits;
 
     /** Total number of misses */
     public final Meter misses;
 
-    /** Total size of buffer pools, in bytes */
+    /** Total size of buffer pools, in bytes, including overflow allocation */
     public final Gauge<Long> size;
 
-    public BufferPoolMetrics()
+    /** Total size, in bytes, of active buffered being used from the pool currently + overflow */
+    public final Gauge<Long> usedSize;

Review comment:
       if it's over-allocated, then `useSize` > `size`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org