You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/01/31 09:20:37 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8373: vfs: Suppoprt F_DUPFD_CLOEXEC
xiaoxiang781216 opened a new pull request, #8373:
URL: https://github.com/apache/nuttx/pull/8373
## Summary
https://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html
## Impact
new F_DUPFD_CLOEXEC
## Testing
internal test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8373: vfs: Suppoprt F_DUPFD_CLOEXEC
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #8373:
URL: https://github.com/apache/nuttx/pull/8373#discussion_r1091996301
##########
fs/vfs/fs_fcntl.c:
##########
@@ -71,7 +71,13 @@ static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap)
{
/* Does not set the errno variable in the event of a failure */
- ret = file_dup(filep, va_arg(ap, int));
+ ret = file_dup(filep, va_arg(ap, int), false);
+ }
+ break;
+
+ case F_DUPFD_CLOEXEC:
+ {
Review Comment:
```suggestion
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8373: vfs: Suppoprt F_DUPFD_CLOEXEC
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #8373:
URL: https://github.com/apache/nuttx/pull/8373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8373: vfs: Suppoprt F_DUPFD_CLOEXEC
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8373:
URL: https://github.com/apache/nuttx/pull/8373#discussion_r1092004856
##########
fs/vfs/fs_fcntl.c:
##########
@@ -71,7 +71,13 @@ static int file_vfcntl(FAR struct file *filep, int cmd, va_list ap)
{
/* Does not set the errno variable in the event of a failure */
- ret = file_dup(filep, va_arg(ap, int));
+ ret = file_dup(filep, va_arg(ap, int), false);
+ }
+ break;
+
+ case F_DUPFD_CLOEXEC:
+ {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org