You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/06/07 17:30:33 UTC
[GitHub] [helix] rabashizade opened a new pull request #1785: Change partition status in Helix UI to be colorblind-friendly
rabashizade opened a new pull request #1785:
URL: https://github.com/apache/helix/pull/1785
This commit changes the partition status colors and adds some signs to the status icons in Helix UI to be more colorblind-friendly.
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1784
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
This PR changes the partition status colors in Helix UI from green/orange to blue(#2196F3)/black(#212121) to be more colorblind- friendly. The colors are chosen such that they have a contrast ratio of at least 3:1 against each other and the background. Moreover, a checkmark is placed in the icon for ready status, and an exclamation point for the not-ready status. Screenshots of the changes are the following:
 
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 merged pull request #1785: Change partition status in Helix UI to be colorblind-friendly
Posted by GitBox <gi...@apache.org>.
zhangmeng916 merged pull request #1785:
URL: https://github.com/apache/helix/pull/1785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rabashizade commented on pull request #1785: Change partition status in Helix UI to be colorblind-friendly
Posted by GitBox <gi...@apache.org>.
rabashizade commented on pull request #1785:
URL: https://github.com/apache/helix/pull/1785#issuecomment-856179167
This PR is ready to be merged, approved by @zhangmeng916.
**Commit message:**
Change partition status in Helix UI to be colorblind-friendly
This commit changes the partition status colors in Helix UI from green/orange to blue(#2196F3)/black(#212121) to be more colorblind-friendly. The colors are chosen such that they have a contrast ratio of at least 3:1 against each other and the background. Moreover, a checkmark is placed in the icon for ready status, and an exclamation point for the not-ready status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org