You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/13 04:59:02 UTC

[GitHub] [beam] Hannah-Jiang commented on issue #11067: [BEAM-9136]Add licenses for dependencies

Hannah-Jiang commented on issue #11067: [BEAM-9136]Add licenses for dependencies
URL: https://github.com/apache/beam/pull/11067#issuecomment-598549251
 
 
   > In terms of checking, this script would fail if it was not able to figure out the license for a dependency. This way whoever adds the new dependency would be responsible for making sure we were able to get its license in order to get the PR green. (We should be building containers as part of our precommits.)
   
   I was thinking to run a daily job to 1). check dependencies and missing/additional license file, 2) create a PR and send out for code review automatically. The PR will be sent to two or three person from a group of approvers without identifying which PRs introduced/removed dependencies, because identifying them is cost expensive.
   
   Is daily check good enough?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services