You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/19 00:25:40 UTC

[GitHub] [beam] boyuanzz edited a comment on pull request #14013: [BEAM-11833] Fix reported watermark after restriction split in UnboundedSourceAsSDFRestrictionTracker

boyuanzz edited a comment on pull request #14013:
URL: https://github.com/apache/beam/pull/14013#issuecomment-781726100


   Hi Jan,
   
   You are right that that UnboundedSourceAsSDFWrapperDoFn doesn't update watermark correctly while tryClaim() is called. I think we should fix UnboundedSourceAsSDFWrapperDoFn instead of EmptyUnboundedSource.EmptyUnboundedReader. Here is my one line fix which does the same thing as yours: https://github.com/apache/beam/pull/14020. I really like your test so would you like to consider patching my fix into your PR if my fix makes sense to you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org