You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/16 10:24:56 UTC
[GitHub] [flink] zhuzhurk commented on a change in pull request #9683: [FLINK-14037]Use same userCodeClassLoader as jobManager in jobClient to fix input/…
zhuzhurk commented on a change in pull request #9683: [FLINK-14037]Use same userCodeClassLoader as jobManager in jobClient to fix input/…
URL: https://github.com/apache/flink/pull/9683#discussion_r324596367
##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/JobWithJars.java
##########
@@ -131,14 +133,22 @@ public static void checkJarFile(URL jar) throws IOException {
}
}
- public static ClassLoader buildUserCodeClassLoader(List<URL> jars, List<URL> classpaths, ClassLoader parent) {
+ public static ClassLoader buildUserCodeClassLoader(
+ List<URL> jars, List<URL> classpaths, ClassLoader parent, Configuration conf) {
Review comment:
Each param should be in a new line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services