You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/07/26 14:29:12 UTC
[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1229
[BugFix] Show checkbox for "Connect to existing process" on interpreter menu.
### What is this PR for?
This PR fixes a bug of showing checkbox for "Connect to existing process" on interpreter menu.
### What type of PR is it?
Bug Fix
### How should this be tested?
Go to interpreter menu and check if checkbox for "Connect to existing process" exists.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin bugfix/showCheckbox
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1229
----
commit bbc3283c7cf21fa7340887ddc3bf7ba7b5b8f689
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-26T14:24:41Z
show checkbox on interpreter menu.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1229
@astroshim Was there a JIRA issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1229
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1229
Merged in Master and branch-0.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1229
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1229
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1229
Looks good to me.
\cc @corneadoug to double-check
Merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1229
okay I'll make it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1229
[BugFix] Show checkbox for "Connect to existing process" on interpreter menu.
### What is this PR for?
This PR fixes a bug of showing checkbox for "Connect to existing process" on interpreter menu.
### What type of PR is it?
Bug Fix
### How should this be tested?
Go to interpreter menu and check if checkbox for "Connect to existing process" exists.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin bugfix/showCheckbox
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1229
----
commit bbc3283c7cf21fa7340887ddc3bf7ba7b5b8f689
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-26T14:24:41Z
show checkbox on interpreter menu.
commit 47ce719eec4076d02eb2895d87f69b2fbc6eaaa5
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-29T03:15:34Z
remove height style on the checkbox
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1229
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1229
[BugFix] Show checkbox for "Connect to existing process" on interpreter menu.
### What is this PR for?
This PR fixes a bug of showing checkbox for "Connect to existing process" on interpreter menu.
### What type of PR is it?
Bug Fix
### How should this be tested?
Go to interpreter menu and check if checkbox for "Connect to existing process" exists.
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin bugfix/showCheckbox
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1229.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1229
----
commit bbc3283c7cf21fa7340887ddc3bf7ba7b5b8f689
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-26T14:24:41Z
show checkbox on interpreter menu.
commit 47ce719eec4076d02eb2895d87f69b2fbc6eaaa5
Author: astroshim <hs...@nflabs.com>
Date: 2016-07-29T03:15:34Z
remove height style on the checkbox
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1229: [BugFix] Show checkbox for "Connect to existing proces...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1229
@astroshim Can you create a JIRA issue for this, or point me to the existing one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1229: [BugFix] Show checkbox for "Connect to existing...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---