[GitHub] [incubator-doris] morningman commented on a change in pull request #5597: [Enhance] Support to configure RocksDB to improve tablet meta store

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #5597:
URL: https://github.com/apache/incubator-doris/pull/5597#discussion_r608290139



##########
File path: be/src/common/config.h
##########
@@ -516,10 +514,23 @@ CONF_Int32(flush_thread_num_per_store, "2");
 // config for tablet meta checkpoint
 CONF_mInt32(tablet_meta_checkpoint_min_new_rowsets_num, "10");
 CONF_mInt32(tablet_meta_checkpoint_min_interval_secs, "600");
+// Thread count of RocksDB uses for background flush and compaction, -1 means the number of cores.
+CONF_mInt32(rocksdb_thread_count, "-1");
+CONF_mInt32(rocksdb_block_cache_mb, "1024");
+CONF_Validator(rocksdb_block_cache_mb, [](int value) -> bool {
+  return value > 0;
+});
+CONF_String(rocksdb_compression_type, "LZ4");

Review comment:
       What is the difference between LZ4 and snappy? Is it necessary to config this?

##########
File path: be/src/common/config.h
##########
@@ -516,10 +514,23 @@ CONF_Int32(flush_thread_num_per_store, "2");
 // config for tablet meta checkpoint
 CONF_mInt32(tablet_meta_checkpoint_min_new_rowsets_num, "10");
 CONF_mInt32(tablet_meta_checkpoint_min_interval_secs, "600");
+// Thread count of RocksDB uses for background flush and compaction, -1 means the number of cores.
+CONF_mInt32(rocksdb_thread_count, "-1");
+CONF_mInt32(rocksdb_block_cache_mb, "1024");

Review comment:
       Is 1024MB the default value of rocksdb cache? Maybe it is too big?
   BTW, `rocksdb_thread_count` and `rocksdb_block_cache_mb` are not mutable configuration, use `CONF_Int32` instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org