[jira] [Commented] (AIRFLOW-2938) Invalid 'extra' field in connection can raise an AttributeError when attempting to edit

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589374#comment-16589374 ] 

ASF GitHub Bot commented on AIRFLOW-2938:
-----------------------------------------

wrp opened a new pull request #3785: [AIRFLOW-2938] Handle improperly formatted extra field in connection …
URL: https://github.com/apache/incubator-airflow/pull/3785
 
 
   …gracefully
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2938
    
   
   ### Description
   
   - [X ] Here are some details about my PR, including screenshots of any UI changes:
   Catch exceptions raised by 'd.get' when hasattr(d, 'get') is false. 
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [ X] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Invalid 'extra' field in connection can raise an AttributeError when attempting to edit
> ---------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-2938
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2938
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: William Pursell
>            Assignee: William Pursell
>            Priority: Minor
>
> When the extra field of a connection is not an iterable json object, attempting to edit the connection can lead to a stack trace "Ooops": 
> AttributeError: 'NoneType' object has no attribute 'get'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)