You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/15 07:27:38 UTC
[GitHub] [kafka] showuon opened a new pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
showuon opened a new pull request #10884:
URL: https://github.com/apache/kafka/pull/10884
Follow up for https://github.com/apache/kafka/pull/10870, found out there are still some system tests using the deprecated `exactly_once_beta`. Update them.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-871928533
@vvcephei @mjsax , could you help review? Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-882474964
@cadonna , sorry, it turns out the version `LATEST_3_0` cannot be tested yet. Remove it to make it work. Thank you.
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.1
session_id: 2021-07-19--014
run time: 3 minutes 0.207 seconds
tests run: 4
passed: 4
failed: 0
ignored: 0
================================================================================
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.5.1
status: PASS
run time: 45.659 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.6.2
status: PASS
run time: 42.687 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.7.1
status: PASS
run time: 45.178 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.8.0
status: PASS
run time: 46.120 seconds
--------------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-882474964
@cadonna , sorry, it turns out the version `LATEST_3_0` cannot be tested yet. Remove it to make it work. Thank you.
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.1
session_id: 2021-07-19--014
run time: 3 minutes 0.207 seconds
tests run: 4
passed: 4
failed: 0
ignored: 0
================================================================================
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.5.1
status: PASS
run time: 45.659 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.6.2
status: PASS
run time: 42.687 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.7.1
status: PASS
run time: 45.178 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.8.0
status: PASS
run time: 46.120 seconds
--------------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-927959086
System tests passed: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4694/console
Build failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-861255370
@vvcephei , please help review this PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-865747301
@vvcephei @mjsax , could you help review? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-878942836
Interesting. I'll take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
cadonna merged pull request #10884:
URL: https://github.com/apache/kafka/pull/10884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-882474964
@cadonna , sorry, it turns out the version `LATEST_3_0` cannot be tested yet. Remove it to make it work. Thank you.
```
SESSION REPORT (ALL TESTS)
ducktape version: 0.8.1
session_id: 2021-07-19--014
run time: 3 minutes 0.207 seconds
tests run: 4
passed: 4
failed: 0
ignored: 0
================================================================================
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.5.1
status: PASS
run time: 45.659 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.6.2
status: PASS
run time: 42.687 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.7.1
status: PASS
run time: 45.178 seconds
--------------------------------------------------------------------------------
test_id: kafkatest.tests.streams.streams_broker_compatibility_test.StreamsBrokerCompatibility.test_compatible_brokers_eos_v2_enabled.broker_version=2.8.0
status: PASS
run time: 46.120 seconds
--------------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-865746830
All failed tests are unrelated.
```
Build / JDK 16 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[1] tlsProtocol=TLSv1.2, useInlinePem=false
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[3] tlsProtocol=TLSv1.3, useInlinePem=false
Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#discussion_r651521106
##########
File path: tests/kafkatest/tests/streams/streams_broker_compatibility_test.py
##########
@@ -114,23 +114,22 @@ def test_compatible_brokers_eos_alpha_enabled(self, broker_version):
self.consumer.stop()
self.kafka.stop()
- # TODO enable after 2.5 is released
- # @parametrize(broker_version=str(LATEST_2_5))
- # def test_compatible_brokers_eos_beta_enabled(self, broker_version):
Review comment:
We forgot to enable it after V2.5. Enable it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-927658380
@showuon Thank you for the ping! I started the system tests on this branch. If they are green, I will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10884:
URL: https://github.com/apache/kafka/pull/10884#issuecomment-927621233
@cadonna , please help take a look when available, to enable an ignored system test, and update the deprecated `exactly_once_beta` to `exactly_once_v2`. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org