You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2019/05/16 20:41:15 UTC

[tomcat] branch 8.5.x updated: Reduce the default HTTP/2 header list size from 4GB to 32kB

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
     new e1df258  Reduce the default HTTP/2 header list size from 4GB to 32kB
e1df258 is described below

commit e1df2580ff7c1324023e4a659a4803e9dd8df9af
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu May 16 21:38:45 2019 +0100

    Reduce the default HTTP/2 header list size from 4GB to 32kB
    
    Aligns Tomcat with typical HTTP/2 implementations.
---
 java/org/apache/coyote/http2/ConnectionSettingsBase.java | 2 +-
 webapps/docs/changelog.xml                               | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/coyote/http2/ConnectionSettingsBase.java b/java/org/apache/coyote/http2/ConnectionSettingsBase.java
index da2f74d..cc4ca57 100644
--- a/java/org/apache/coyote/http2/ConnectionSettingsBase.java
+++ b/java/org/apache/coyote/http2/ConnectionSettingsBase.java
@@ -43,7 +43,7 @@ public abstract class ConnectionSettingsBase<T extends Throwable> {
     protected static final long DEFAULT_MAX_CONCURRENT_STREAMS = UNLIMITED;
     protected static final int DEFAULT_INITIAL_WINDOW_SIZE = (1 << 16) - 1;
     protected static final int DEFAULT_MAX_FRAME_SIZE = MIN_MAX_FRAME_SIZE;
-    protected static final long DEFAULT_MAX_HEADER_LIST_SIZE = UNLIMITED;
+    protected static final long DEFAULT_MAX_HEADER_LIST_SIZE = 1 << 15;
 
     protected Map<Setting,Long> current = new HashMap<>();
     protected Map<Setting,Long> pending = new HashMap<>();
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 7133b44..22eb3a0 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -75,6 +75,10 @@
         <code>Http2Protocol</code> from 200 to 100 to align with typical
         defaults for HTTP/2 implementations. (markt)
       </update>
+      <update>
+        Reduce the default HTTP/2 header list size from 4GB to 32kB to align
+        with typical HTTP/2 implementations. (markt)
+      </update>
     </changelog>
   </subsection>
   <subsection name="Cluster">


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org