You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2023/01/20 12:37:19 UTC
[GitHub] [incubator-hugegraph] zyxxoo commented on a diff in pull request #2095: refact: mark TODO in the license problem code & use standard UTF-8
zyxxoo commented on code in PR #2095:
URL: https://github.com/apache/incubator-hugegraph/pull/2095#discussion_r1081532122
##########
hugegraph-core/src/main/java/org/apache/hugegraph/traversal/optimize/HugeScriptTraversal.java:
##########
@@ -32,6 +32,7 @@
import org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal;
/**
+ * TODO: lack LICENSE reference
Review Comment:
look like "https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/ScriptTraversal.java"
should i add APV2 to the annotation? we license and the origin license is same
##########
hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/AnsjAnalyzer.java:
##########
@@ -32,6 +32,7 @@
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
the refer can replace with https://github.com/NLPchina/ansj_seg/wiki
##########
hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JcsegAnalyzer.java:
##########
@@ -33,6 +33,7 @@
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
replace with https://github.com/lionsoul2014/jcseg
##########
hugegraph-core/src/main/java/org/apache/hugegraph/type/Nameable.java:
##########
@@ -18,6 +18,7 @@
package org.apache.hugegraph.type;
/**
+ * TODO: lack license header & LICENSE reference
Review Comment:
https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-core/src/main/java/org/janusgraph/core/Namifiable.java
ditto, should I Change the license to janusgraph license?should I modify the license?
##########
hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/SmartCNAnalyzer.java:
##########
@@ -29,6 +29,7 @@
import org.apache.hugegraph.util.InsertionOrderUtil;
/**
+ * TODO: ensure the refer is valid & clear
* Reference from https://my.oschina.net/apdplat/blog/412921
*/
public class SmartCNAnalyzer implements Analyzer {
Review Comment:
replace with https://lucene.apache.org/core/8_11_2/analyzers-smartcn/index.html
##########
hugegraph-core/src/main/java/org/apache/hugegraph/util/StringEncoding.java:
##########
@@ -17,19 +17,22 @@
package org.apache.hugegraph.util;
-import java.io.UnsupportedEncodingException;
+import static java.nio.charset.StandardCharsets.UTF_8;
+
+import java.io.IOException;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.Base64;
import java.util.UUID;
-import org.mindrot.jbcrypt.BCrypt;
-
import org.apache.hugegraph.HugeException;
import org.apache.hugegraph.backend.serializer.BytesBuffer;
+import org.mindrot.jbcrypt.BCrypt;
+
import com.google.common.base.CharMatcher;
/**
+ * TODO: lack license header & LICENSE reference
Review Comment:
https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-core/src/main/java/org/janusgraph/util/encoding/StringEncoding.java
The janusgraph also is APV2 license, should i keep the janusgraph origin license? should i modify our license file?
##########
hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/IKAnalyzer.java:
##########
@@ -30,6 +30,7 @@
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
the reference replace with https://github.com/yyn0210/IKAnalyzer
##########
hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java:
##########
@@ -94,7 +94,8 @@ public Id generate(HugeVertex vertex) {
return this.generate();
}
- /*
+ /**
+ * TODO: lack LICENSE reference & seems need move to header
Review Comment:
pr 2093 fix
##########
hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/JiebaAnalyzer.java:
##########
@@ -27,6 +27,7 @@
import com.huaban.analysis.jieba.SegToken;
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
replace with https://github.com/huaban/jieba-analysis
##########
hugegraph-core/src/main/java/org/apache/hugegraph/util/GZipUtil.java:
##########
@@ -27,6 +27,7 @@
import org.apache.hugegraph.backend.serializer.BytesBuffer;
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
ditto, We looked at the code on the blog, maybe we can remove the reference, because the code is a common util
##########
hugegraph-api/src/main/java/org/apache/hugegraph/api/job/GremlinAPI.java:
##########
@@ -150,7 +150,7 @@ public String name() {
return firstLine;
}
- /*
+ /* TODO: ensure the refer is valid
Review Comment:
the refer look like can remove
##########
hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/MMSeg4JAnalyzer.java:
##########
@@ -34,6 +34,7 @@
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
replace with https://github.com/chenlb/mmseg4j-core
##########
hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/IKAnalyzer.java:
##########
@@ -30,6 +30,7 @@
import com.google.common.collect.ImmutableList;
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
I will change to download jar
##########
hugegraph-core/src/main/java/org/apache/hugegraph/analyzer/HanLPAnalyzer.java:
##########
@@ -33,6 +33,7 @@
import com.hankcs.hanlp.tokenizer.StandardTokenizer;
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
replace with https://github.com/hankcs/HanLP/wiki
##########
hugegraph-core/src/main/java/org/apache/hugegraph/type/define/Cardinality.java:
##########
@@ -20,6 +20,7 @@
import org.apache.tinkerpop.gremlin.structure.VertexProperty;
/**
+ * TODO: lack license header & LICENSE reference
Review Comment:
https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-core/src/main/java/org/janusgraph/core/Cardinality.java
https://github.com/JanusGraph/janusgraph/blob/master/janusgraph-core/src/main/java/org/janusgraph/core/Namifiable.java
ditto, should I Change the license to janusgraph license?should I modify the license?
##########
hugegraph-core/src/main/java/org/apache/hugegraph/util/CompressUtil.java:
##########
@@ -57,6 +57,7 @@
public final class CompressUtil {
/**
+ * TODO: ensure the refer is valid & clear
Review Comment:
We looked at the code on the blog, maybe we can remove the reference, because the code is a common util
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org