[jira] Issue Comment Edited: (OFBIZ-2518) Datafile additions, fixes and other stuff

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754570#action_12754570 ] 

Jacques Le Roux edited comment on OFBIZ-2518 at 9/12/09 10:44 AM:
------------------------------------------------------------------

Hi BJ,

I was able to apply the patch but there are at least 2 points that would help to be done besides Peter's remark
# minor : don't add the 1st 2 lines in your patch when creating from Eclipse, see ["(don't use finish and select project to avoid the 2 1st lines in the patch)"|http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)]
# I wonder if you have a setting in Eclipse for the width of the files (it seems that they are not much larger than 93 chars.). ? It not the 1st time I see that in your patches, that's why I ask that.

*EDIT : larger replaced by width*

      was (Author: jacques.le.roux):
    Hi BJ,

I was able to apply the patch but there are at least 2 points that would help to be done besides Peter's remark
# minor : don't add the 1st 2 lines in your patch when creating from Eclipse, see ["(don't use finish and select project to avoid the 2 1st lines in the patch)"|http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices#OFBizContributorsBestPractices-HowtoSendinYourContributions(orhowtocreateandapplypatches)]
# I wonder if you have a setting in Eclipse for the larger of the files (it seems that they are not much larger than 93 chars.). ? It not the 1st time I see that in your patches that's why I ask that
  
> Datafile additions, fixes and other stuff
> -----------------------------------------
>
>                 Key: OFBIZ-2518
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2518
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: BJ Freeman
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: datafiles.xsd, goodident.xml, OFBIZ-2518-Datafile_xsd.patch, Product_Data_327766_1.xls
>
>
> First is to figure out what all it supposed to do and document the Xsd.
> Then if I have missed something will check to make sure it works.
> finally add new functionaliity
> Yes I know you can program like with zipsales.
> but right now I want to be able to just create entity files that will load through webtools.
> 1) using a tab delimited file that has a header.
> 2) some of the fields have quoted around them that need to be removed.
> 3) Need to declare entity field not in the file and put in values. Like unit of messure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.