[GitHub] [ignite] anton-vinogradov commented on a change in pull request #7795: IGNITE-12989 TxRecovery should log statuses to TimeBag

[GitBox <gi...@apache.org>]

anton-vinogradov commented on a change in pull request #7795:
URL: https://github.com/apache/ignite/pull/7795#discussion_r425775079



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java
##########
@@ -3051,6 +3073,37 @@ else if (tx.setRollbackOnly())
                 cctx.kernalContext().gateway().readUnlock();
             }
         }
+
+        /**
+         * @param tx Tx.
+         * @param failedNode Failed node.
+         */
+        private void processPrepared(IgniteInternalTx tx, UUID failedNode) {
+            IgniteInternalFuture<Boolean> fut = commitIfPrepared(tx, Collections.singleton(failedNode));
+
+            if (fut != null)
+                doneFut.add(fut);
+
+            txCnt.incrementAndGet();
+        }
+
+        /**
+         *
+         */
+        private void finishAndRecordTimings() {
+            timeBag.finishGlobalStage("Finished");
+
+            StringBuilder timingsToLog = new StringBuilder();
+
+            timingsToLog.append("TxRecovery Status and Timings [txs=").append(txCnt.get());
+
+            for (String stageTiming : timeBag.stagesTimings())
+                timingsToLog.append(", ").append(stageTiming);
+
+            timingsToLog.append("]");
+
+            log.info(timingsToLog.toString());

Review comment:
       done

##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java
##########
@@ -2959,6 +2972,8 @@ private TxRecoveryInitRunnable(ClusterNode node, MvccCoordinator mvccCrd) {
 
         /** {@inheritDoc} */
         @Override public void run() {
+            timeBag.finishGlobalStage("Started");

Review comment:
       done

##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/transactions/IgniteTxManager.java
##########
@@ -3016,6 +3031,13 @@ else if (tx.setRollbackOnly())
                     }
                 }
 
+                timeBag.finishGlobalStage("Initialized");

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org