You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/01/07 12:27:19 UTC
[GitHub] [cordova-electron] erisu opened a new pull request #182: fix: restrict deep merging on reserved keys
erisu opened a new pull request #182:
URL: https://github.com/apache/cordova-electron/pull/182
### Motivation, Context & Description
* Reject deep merge on reserved keys
### Testing
* `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] dpogue merged pull request #182: fix: restrict deep merging on reserved keys
Posted by GitBox <gi...@apache.org>.
dpogue merged pull request #182:
URL: https://github.com/apache/cordova-electron/pull/182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] codecov-io edited a comment on pull request #182: fix: restrict deep merging on reserved keys
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #182:
URL: https://github.com/apache/cordova-electron/pull/182#issuecomment-756087157
# [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=h1) Report
> Merging [#182](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=desc) (7a0fc55) into [master](https://codecov.io/gh/apache/cordova-electron/commit/b2617a94d4a8a859454850054d2b87748ec957e8?el=desc) (b2617a9) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #182 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 652 654 +2
=========================================
+ Hits 652 654 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [lib/util.js](https://codecov.io/gh/apache/cordova-electron/pull/182/diff?src=pr&el=tree#diff-bGliL3V0aWwuanM=) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=footer). Last update [b2617a9...7a0fc55](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] codecov-io commented on pull request #182: fix: restrict deep merging on reserved keys
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #182:
URL: https://github.com/apache/cordova-electron/pull/182#issuecomment-756087157
# [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=h1) Report
> Merging [#182](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=desc) (7a0fc55) into [master](https://codecov.io/gh/apache/cordova-electron/commit/b2617a94d4a8a859454850054d2b87748ec957e8?el=desc) (b2617a9) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #182 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 652 654 +2
=========================================
+ Hits 652 654 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [lib/util.js](https://codecov.io/gh/apache/cordova-electron/pull/182/diff?src=pr&el=tree#diff-bGliL3V0aWwuanM=) | `100.00% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=footer). Last update [b2617a9...7a0fc55](https://codecov.io/gh/apache/cordova-electron/pull/182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org