You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/08/13 22:22:47 UTC

Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68327/
-----------------------------------------------------------

Review request for mesos, Gastón Kleiman and Meng Zhu.


Repository: mesos


Description
-------

Added tests for FUTURE_EXITED and DROP_EXITED.


Diffs
-----

  3rdparty/libprocess/src/tests/process_tests.cpp 17ed2f45c892a3c1c34040a492ad3fdd4a7552c1 


Diff: https://reviews.apache.org/r/68327/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68327/#review207264
-----------------------------------------------------------




3rdparty/libprocess/src/tests/process_tests.cpp
Lines 764 (patched)
<https://reviews.apache.org/r/68327/#comment290598>

    s/Proces/Process/ here and below


- Benjamin Mahler


On Aug. 13, 2018, 10:22 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68327/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 10:22 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for FUTURE_EXITED and DROP_EXITED.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 17ed2f45c892a3c1c34040a492ad3fdd4a7552c1 
> 
> 
> Diff: https://reviews.apache.org/r/68327/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

Posted by Benjamin Mahler <bm...@apache.org>.


> On Aug. 14, 2018, 10:09 p.m., Gastón Kleiman wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Lines 762-763 (patched)
> > <https://reviews.apache.org/r/68327/diff/1/?file=2072112#file2072112line762>
> >
> >     Can we add a description?
> >     
> >     Something like:
> >     
> >     ```
> >     Verifies that its possible to intercept `ExitedEvent` events sent to a process upon termination of another process that it is linked to.
> >     ``

I've updated the test name to FutureExited and DropExited to clarify this, hopefully now the description isn't needed?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68327/#review207257
-----------------------------------------------------------


On Aug. 13, 2018, 10:22 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68327/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 10:22 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for FUTURE_EXITED and DROP_EXITED.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 17ed2f45c892a3c1c34040a492ad3fdd4a7552c1 
> 
> 
> Diff: https://reviews.apache.org/r/68327/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

Posted by Benjamin Mahler <bm...@apache.org>.


> On Aug. 14, 2018, 10:09 p.m., Gastón Kleiman wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Lines 766-767 (patched)
> > <https://reviews.apache.org/r/68327/diff/1/?file=2072112#file2072112line766>
> >
> >     This might make the test easier to read:
> >     
> >     ```
> >     s/pid/linkedPid/ (or maybe exitingProcessPid? receiver? linkee?)
> >     s/process/linker/
> >     ```
> >     
> >     `ProcessRemoteLinkTest.RemoteDoubleLinkRelink` uses similar names.

This was copy pasted, but I'm all for making it more readable! I'll update these and leave the existing tests as is for now.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68327/#review207257
-----------------------------------------------------------


On Aug. 13, 2018, 10:22 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68327/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 10:22 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for FUTURE_EXITED and DROP_EXITED.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 17ed2f45c892a3c1c34040a492ad3fdd4a7552c1 
> 
> 
> Diff: https://reviews.apache.org/r/68327/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

Posted by Gastón Kleiman <ga...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68327/#review207257
-----------------------------------------------------------




3rdparty/libprocess/src/tests/process_tests.cpp
Lines 762-763 (patched)
<https://reviews.apache.org/r/68327/#comment290589>

    Can we add a description?
    
    Something like:
    
    ```
    Verifies that its possible to intercept `ExitedEvent` events sent to a process upon termination of another process that it is linked to.
    ``



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 766-767 (patched)
<https://reviews.apache.org/r/68327/#comment290590>

    This might make the test easier to read:
    
    ```
    s/pid/linkedPid/ (or maybe exitingProcessPid? receiver? linkee?)
    s/process/linker/
    ```
    
    `ProcessRemoteLinkTest.RemoteDoubleLinkRelink` uses similar names.



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 776 (patched)
<https://reviews.apache.org/r/68327/#comment290591>

    I'd add an empty line here, to make it consistent with `ProcessTest.Exited` and making it more obvious that the process being terminated is not the same one that was just spawn.



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 788 (patched)
<https://reviews.apache.org/r/68327/#comment290593>

    Ditto adding a description.



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 800 (patched)
<https://reviews.apache.org/r/68327/#comment290592>

    Ditto empty line.


- Gastón Kleiman


On Aug. 13, 2018, 3:22 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68327/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 3:22 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for FUTURE_EXITED and DROP_EXITED.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 17ed2f45c892a3c1c34040a492ad3fdd4a7552c1 
> 
> 
> Diff: https://reviews.apache.org/r/68327/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.

Posted by Gastón Kleiman <ga...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68327/#review207278
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On Aug. 13, 2018, 3:22 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68327/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 3:22 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for FUTURE_EXITED and DROP_EXITED.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 17ed2f45c892a3c1c34040a492ad3fdd4a7552c1 
> 
> 
> Diff: https://reviews.apache.org/r/68327/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>