You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/13 18:16:53 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
EricGao888 opened a new pull request, #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434
## Purpose of the pull request
* Currently, zeppelin task plugin only allows users to schedule one zeppelin paragraph at a time. After this PR, users will be able to schedule a whole zeppelin note, which is composed of multiple paragraphs at a time.
* This PR closes: #9798
## Brief change log
* Already described above.
## Verify this pull request
* Verified by both unit test and manual test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1154619919
There are some flaky in ```FileManageE2ETest```. I've restart the CI. @EricGao888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1157470170
@SbloodyS Could you please take a look when you have time? Thx~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1157475202
> LGTM overall. But we still have unresolved comment in [#10434 (comment)](https://github.com/apache/dolphinscheduler/pull/10434#discussion_r896323887)
Ops, I think I missed one comment. Will add some changes in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#discussion_r896325641
##########
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-zeppelin.ts:
##########
@@ -45,16 +45,16 @@ export function useZeppelin(model: { [field: string]: any }): IJsonItem[] {
name: t('project.node.zeppelin_paragraph_id'),
props: {
placeholder: t('project.node.zeppelin_paragraph_id_tips')
- },
- validate: {
- trigger: ['input', 'blur'],
- required: true,
- validator(validate: any, value: string) {
- if (!value) {
- return new Error(t('project.node.zeppelin_paragraph_id_tips'))
- }
- }
}
+// validate: {
Review Comment:
Sure, will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1159361451
> 
> Looks like some kind of timezone related issue?
@EricGao888 seem we already fix in https://github.com/apache/dolphinscheduler/pull/10284, could you please rebase on upstream dev and try again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#discussion_r896323887
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTask.java:
##########
@@ -85,11 +87,32 @@ public void handle() throws Exception {
}
// Submit zeppelin task
- ParagraphResult paragraphResult = this.zClient.executeParagraph(noteId, paragraphId, zeppelinParamsMap);
- String resultContent = paragraphResult.getResultInText();
- Status status = paragraphResult.getStatus();
- final int exitStatusCode = mapStatusToExitCode(status);
+ String resultContent;
+ Status status = Status.FINISHED;
+ if (paragraphId == null) {
+ NoteResult noteResult = this.zClient.executeNote(noteId, zeppelinParamsMap);
+ List<ParagraphResult> paragraphResultList = noteResult.getParagraphResultList();
+ StringBuilder resultContentBuilder = new StringBuilder();
+ for (ParagraphResult paragraphResult : paragraphResultList) {
+ resultContentBuilder.append(
+ String.format(
+ "paragraph_id: %s, paragraph_result: %s\n",
+ paragraphResult.getParagraphId(),
+ paragraphResult.getResultInText()));
+ status = paragraphResult.getStatus();
+ if (status != Status.FINISHED) {
Review Comment:
Does it mean failure if status is not FINISHED? If so, I think it's better to add some comments.
##########
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-zeppelin.ts:
##########
@@ -45,16 +45,16 @@ export function useZeppelin(model: { [field: string]: any }): IJsonItem[] {
name: t('project.node.zeppelin_paragraph_id'),
props: {
placeholder: t('project.node.zeppelin_paragraph_id_tips')
- },
- validate: {
- trigger: ['input', 'blur'],
- required: true,
- validator(validate: any, value: string) {
- if (!value) {
- return new Error(t('project.node.zeppelin_paragraph_id_tips'))
- }
- }
}
+// validate: {
Review Comment:
I think it should be removed if unuse, WDYT? @songjianet @Amy0104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1154252945
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10434?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10434](https://codecov.io/gh/apache/dolphinscheduler/pull/10434?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ca4bdc) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/190f253083e2b1d50f235b07c53fbbe6b66c1aa2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (190f253) will **decrease** coverage by `0.00%`.
> The diff coverage is `36.36%`.
```diff
@@ Coverage Diff @@
## dev #10434 +/- ##
============================================
- Coverage 40.55% 40.54% -0.01%
- Complexity 4774 4775 +1
============================================
Files 878 878
Lines 35741 35764 +23
Branches 3969 3973 +4
============================================
+ Hits 14493 14501 +8
- Misses 19805 19820 +15
Partials 1443 1443
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10434?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inscheduler/plugin/task/zeppelin/ZeppelinTask.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stemVwcGVsaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svemVwcGVsaW4vWmVwcGVsaW5UYXNrLmphdmE=) | `48.68% <34.37%> (-7.92%)` | :arrow_down: |
| [...duler/plugin/task/zeppelin/ZeppelinParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10434/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stemVwcGVsaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svemVwcGVsaW4vWmVwcGVsaW5QYXJhbWV0ZXJzLmphdmE=) | `84.61% <100.00%> (+7.69%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10434?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10434?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [190f253...8ca4bdc](https://codecov.io/gh/apache/dolphinscheduler/pull/10434?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1154259347
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10434)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list) [42.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1159362557
> LGTM overall. But we still have unresolved comment in [#10434 (comment)](https://github.com/apache/dolphinscheduler/pull/10434#discussion_r896323887)
It already added and seem this PR ready to go now is it? @SbloodyS @EricGao888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1158458646
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10434)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list) [42.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1154951070
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10434)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [27 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list) [16.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1157524979
Looks like some kind of timezone related issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1157473613
> LGTM overall. But we still have unresolved comment in [#10434 (comment)](https://github.com/apache/dolphinscheduler/pull/10434#discussion_r896323887)
I've already removed all the redundant commented code in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1154619054
I'm not sure why E2E fails for resource center test. Could anyone plz help restart the test? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1155178255
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10434)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list) [42.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#discussion_r898926818
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTask.java:
##########
@@ -85,11 +87,32 @@ public void handle() throws Exception {
}
// Submit zeppelin task
- ParagraphResult paragraphResult = this.zClient.executeParagraph(noteId, paragraphId, zeppelinParamsMap);
- String resultContent = paragraphResult.getResultInText();
- Status status = paragraphResult.getStatus();
- final int exitStatusCode = mapStatusToExitCode(status);
+ String resultContent;
+ Status status = Status.FINISHED;
+ if (paragraphId == null) {
+ NoteResult noteResult = this.zClient.executeNote(noteId, zeppelinParamsMap);
+ List<ParagraphResult> paragraphResultList = noteResult.getParagraphResultList();
+ StringBuilder resultContentBuilder = new StringBuilder();
+ for (ParagraphResult paragraphResult : paragraphResultList) {
+ resultContentBuilder.append(
+ String.format(
+ "paragraph_id: %s, paragraph_result: %s\n",
+ paragraphResult.getParagraphId(),
+ paragraphResult.getResultInText()));
+ status = paragraphResult.getStatus();
+ if (status != Status.FINISHED) {
Review Comment:
Sure, comments added in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1154904203
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10434)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL) [27 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10434&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list) [16.2% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10434&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1159363702
> > There are some flaky in `FileManageE2ETest`. I've restarted the CI. @EricGao888
>
> @SbloodyS what is that? and could we find some way to fix it?
It have been fixed in #10450.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1155104364
Could anyone please help restart the CI? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1159361585
> > 
> > Looks like some kind of timezone related issue?
>
> @EricGao888 seem we already fix in #10284, could you please rebase on upstream dev and try again?
@zhongjiajie I had already rebased and the CI succeeded. Thx for the reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1159363776
> > LGTM overall. But we still have unresolved comment in [#10434 (comment)](https://github.com/apache/dolphinscheduler/pull/10434#discussion_r896323887)
>
> It already added and seem this PR ready to go now is it? @SbloodyS @EricGao888
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1159362861
>
@zhongjiajie I think so, comments added in the latest PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10434: [Feature][Task Plugin] Enable zeppelin task to schedule a whole zeppelin note
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10434:
URL: https://github.com/apache/dolphinscheduler/pull/10434#issuecomment-1159361030
> There are some flaky in `FileManageE2ETest`. I've restarted the CI. @EricGao888
@SbloodyS what is that? and could we find some way to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org