You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fatschi <gi...@git.apache.org> on 2014/10/01 16:59:03 UTC

[GitHub] incubator-flink pull request: Flink 1134

GitHub user fatschi opened a pull request:

    https://github.com/apache/incubator-flink/pull/138

    Flink 1134

    fix for https://issues.apache.org/jira/browse/FLINK-1134

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fatschi/incubator-flink FLINK_1134

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
    
----
commit d28c8412e465088f7077d45106534e8d8ac8b56a
Author: Fabian Tschirschnitz <fa...@googlemail.com>
Date:   2014-10-01T14:46:54Z

    [FLINK-1134] tried to fix issue with not terminating JVM when using RemoteCollectorOutputFormat
    
    Conflicts:
    	flink-java/src/main/java/org/apache/flink/api/java/io/RemoteCollectorImpl.java

commit b58f337e4e2e07066d6588214d7c2d50cd062fe5
Author: Fabian Tschirschnitz <fa...@googlemail.com>
Date:   2014-10-01T14:57:25Z

    [FLINK-1134] fixed javadocs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Flink 1134

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/138#discussion_r18384247
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/RemoteCollectorImpl.java ---
    @@ -75,6 +87,8 @@
     
     			registry = LocateRegistry.createRegistry(port);
     			registry.bind(rmiId, collectorInstance);
    +			
    +			registries.add(registry);
     		} catch (RemoteException e) {
     			e.printStackTrace();
    --- End diff --
    
    I would recommend the re-throw such exceptions as RuntimeExceptions! If you are printing the stack-trace, just the stack trace (without error message) will appear on some TaskManager's log files. 
    if you throw a RuntimeE., the job execution will abort and the user will see the exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: Flink 1134

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-flink/pull/138


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---