[Bug 3940] ArchiveIterator uses opt_j for two different things

[bu...@bugzilla.spamassassin.org]

http://bugzilla.spamassassin.org/show_bug.cgi?id=3940





------- Additional Comments From jm@jmason.org  2004-10-31 16:25 -------
Subject: Re:  ArchiveIterator uses opt_j for two different things 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


> > I'd strongly prefer (I'm probably -1 on creatingh two new options for
> > this one) to keep opt_j as the number of processes (it parallels "make
> > -j") and add a new option for the temporary file vs. in-memory option.
> > The temporary file thing postdates -j by a long period and can just move
> > to a new option.
> 
> I think just adding a new option for storage is doable, but FWIW I don't
> really care about "parallels ... -j" since this is all internal API names.
> The commandline can stay the same, but unless you're used to the module,
> "opt_j" isn't very descriptive of what the value means.

oh btw, on that point, I'd be very pro adding *new*, meaningful names
for opt_j, opt_n et al as they are used in the
M:SpamAssassin:ArchiveIterator class, and leaving opt_j, opt_n et al
as backwards-compat aliases.   I agree, they don't make much sense
for users of that module apart from mass-check.

- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBhYJGMJF5cimLx9ARAnZWAKCFHqthUt9p7kCQJTqkLsAjBqXWTACZAcd+
lReIi6mhyf165yWgmgAmtJI=
=BMAd
-----END PGP SIGNATURE-----





------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.