[GitHub] [nifi-minifi-cpp] phrocker commented on a change in pull request #589: MINIFICPP-914: Incur wait while awaiting minifi shutdown during restart

[GitBox <gi...@apache.org>]

phrocker commented on a change in pull request #589: MINIFICPP-914: Incur wait while awaiting minifi shutdown during restart
URL: https://github.com/apache/nifi-minifi-cpp/pull/589#discussion_r292399105
 
 

 ##########
 File path: bin/minifi.sh
 ##########
 @@ -252,7 +252,12 @@ case "\$1" in
     restart)
         echo Restarting MiNiFi service
         \${bin_dir}/minifi.sh stop
-        \${bin_dir}/minifi.sh start
+	if [ "${saved_pid}" -gt 0 ]; then
+	        while [ $(active_pid ${saved_pid}) -eq 0 ]; do
 
 Review comment:
   My initial thought was that the user can ctrl+c either the service case or the agent restart case to determine why it didn't restart; however, I think we can give them the option to ctrl+c to forcibly terminate, even in the service case. kill -9 is safe to the processes. I'll make that quick update and you can take a look.
   
    There will always be some who have the opinion that we should wait and terminate and others will have the opinion that we should ctrl+c and allow investigation ( I had this same issue on another open source project I support ) -- but I think we should make the service and agent restart paths the same no matter the community preferred route. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services