You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stevengill <gi...@git.apache.org> on 2016/06/01 23:47:11 UTC

[GitHub] cordova-lib pull request #447: attempting to fix failing travis and appveyor...

GitHub user stevengill opened a pull request:

    https://github.com/apache/cordova-lib/pull/447

    attempting to fix failing travis and appveyor tests

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stevengill/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #447
    
----
commit 812da4f8ccbc039e318aa7aea4fd2dc42690e035
Author: Steve Gill <st...@gmail.com>
Date:   2016-06-01T23:46:29Z

    attempting to fix failing travis and appveyor tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib issue #447: attempting to fix failing travis and appveyor tests

Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:

    https://github.com/apache/cordova-lib/pull/447
  
    I ended up removing the fetch tests from travis for now. Better to having passing travis tests than a weird node 6 module missing issue that I can't reproduce


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib issue #447: attempting to fix failing travis and appveyor tests

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-lib/pull/447
  
    ## [Current coverage][cc-pull] is **80.59%**
    > Merging [#447][cc-pull] into [master][cc-base-branch] will not change coverage
    
    ```diff
    @@             master       #447   diff @@
    ==========================================
      Files            68         68          
      Lines          5384       5384          
      Methods         851        851          
      Messages          0          0          
      Branches       1041       1041          
    ==========================================
      Hits           4339       4339          
      Misses         1045       1045          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [cc0e0e9...9e52611][cc-compare]
    [cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
    [cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/cc0e0e9ac2f1a589bb6a13be4a1d4299fe1bdba1...9e526113d731c5c510cd60c955abf033e17dbc4a
    [cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/447?src=pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request #447: attempting to fix failing travis and appveyor...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/447


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib issue #447: attempting to fix failing travis and appveyor tests

Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:

    https://github.com/apache/cordova-lib/pull/447
  
    cordova-fetch tests are failing due to missing modules for node 6. Works fine locally for me though. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org