You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/09/21 19:18:48 UTC
Review Request 68800: Removed bundled libev patch.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68800/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-895
https://issues.apache.org/jira/browse/MESOS-895
Repository: mesos
Description
-------
Since we now diable the libev SIGCHLD handler at runtime, we no longer
need to bundle the patch to do it at build time. It is still useful to
bundle libev itself, to support older distributions.
Diffs
-----
3rdparty/Makefile.am a6709ff9c7ef81896174ed4d35e1b1da9bb33757
3rdparty/libev-4.22.patch 2d21f9fb3b6c5a4347beb1e9633a2ab63eae4647
Diff: https://reviews.apache.org/r/68800/diff/1/
Testing
-------
make check (Fedora 28)
Thanks,
James Peach
Re: Review Request 68800: Removed bundled libev patch.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68800/#review208884
-----------------------------------------------------------
PASS: Mesos patch 68800 was successfully built and tested.
Reviews applied: `['68800']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2371/mesos-review-68800
- Mesos Reviewbot Windows
On Sept. 21, 2018, 7:18 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68800/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 7:18 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-895
> https://issues.apache.org/jira/browse/MESOS-895
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we now disable the libev SIGCHLD handler at runtime, we no longer
> need to bundle the patch to do it at build time. It is still useful to
> bundle libev itself, to support older distributions.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am a6709ff9c7ef81896174ed4d35e1b1da9bb33757
> 3rdparty/libev-4.22.patch 2d21f9fb3b6c5a4347beb1e9633a2ab63eae4647
>
>
> Diff: https://reviews.apache.org/r/68800/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 68800: Removed bundled libev patch.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68800/#review208881
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Sept. 21, 2018, 7:18 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68800/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2018, 7:18 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-895
> https://issues.apache.org/jira/browse/MESOS-895
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since we now disable the libev SIGCHLD handler at runtime, we no longer
> need to bundle the patch to do it at build time. It is still useful to
> bundle libev itself, to support older distributions.
>
>
> Diffs
> -----
>
> 3rdparty/Makefile.am a6709ff9c7ef81896174ed4d35e1b1da9bb33757
> 3rdparty/libev-4.22.patch 2d21f9fb3b6c5a4347beb1e9633a2ab63eae4647
>
>
> Diff: https://reviews.apache.org/r/68800/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 28)
>
>
> Thanks,
>
> James Peach
>
>