You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/12/20 11:48:53 UTC

Review Request 54889: Handled all possible offers in test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54889/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-6820
    https://issues.apache.org/jira/browse/MESOS-6820


Repository: mesos


Description
-------

The test FaultToleranceTest.FrameworkReregister observes a single
offer in order to monitor progress and as a trigger to initiate other
orders later in the test. The change installs expectations for
possibly additional offers. This allows for the thread running the
test body to be delayed with respect to the master thread which could
in the meantime hand out additional offers.


Diffs
-----

  src/tests/fault_tolerance_tests.cpp 05937a917a2c175aa53b52488febb7cfd8400a13 

Diff: https://reviews.apache.org/r/54889/diff/


Testing
-------

`make check` (OS X, clang-trunk, w/ optimizations, SSL)

Before this fix `FaultToleranceTest.FrameworkReregister` failed for me multiple times in ~10k iterations; after this patch it didn't fail in a single run I stopped after 170k iterations.


Thanks,

Benjamin Bannier