You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/08/03 14:49:54 UTC
Review Request 37034: LENS-709: Remove code which is only present for
java6 compatibility
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37034/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-709
https://issues.apache.org/jira/browse/LENS-709
Repository: lens
Description
-------
Diffs
-----
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java 5938f8a2666956a6cb278399710df9a820d7f755
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java ff046c7af3239dc82535bedb8f0f545189089db5
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java ac2957dae3a003dcbff78b5e421b0e613dbb4447
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069ed7d7f14f74f6c588bd33c2e542929fce
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2b3f7e3f8406cd4f3833d7499aa573a56f8e60d6
lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java cb226d5814c9dfead7668f7b93ea0804e97985d8
lens-server/src/main/java/org/apache/lens/server/LensServer.java 0da37ad944c426dcce046bd5443428e7b4438c39
lens-server/src/main/java/org/apache/lens/server/LensServices.java c4a61c845a319bbb7ec7e21513ed1fefdf047be8
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7ef804624711e89ef981b83a6576cbc9dc00fb0
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java e430324f74335a97346ba63ad9d6f6297fc4efc7
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java e0043187aa6d9e6ec5eee0d1200c6a8b587113aa
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java fce9cf57413600918952ddb2f13d885af408efe9
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 2295248b13138ec50e8012fcf9b947127488114d
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 79ebe28104115c1da400babcc17df3ceed468069
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java ab5be32960389b65445a724c7507a2c026c9ddf1
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 63d7b9c30b88220ffc04c0d5ccf1c402def2c134
lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java a23399891cb48bd0a19089474aab77584acf2b65
lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 81ad260d0c8ac5f54c4f2cf0bcf7dd81617006b1
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 41444160b5e3184b83a0acce92abbc30c5ebb02f
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 3f4d04a993f18e9d67777126236e03ea4fa7b7b4
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java da3bfd13093de03380cb07c104dbbd006a121498
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java ed2552c8df6329b4ec5c49066e41f00644ef024d
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 01db2626ec9a36eb454b3c0543f8f5fff2bd9b90
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 2beb3b9f1244f0694341f8f37c3d5173ca2f0502
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4c8a583708b0cbfbbbf4cbe207d1711d9af3045b
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java af14fd6620376cc0e16103ec4eb7f650ab40c092
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5edbd134e1978becc103a228a90e883de1bb0d30
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 1747d0302a4d831271964f2229b33ca445783b3b
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java bdd49f5e733b4abdab0a5d66d7dc00661fa08a4d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java c17b28bd29112f9af054dcc478d069f71ba396b2
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java 52402a0b0a89dbb1d1d22fa5c04ed185c97d1166
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 5f2cbfd5dde34d894e495d6a3cd4e76739c1b852
Diff: https://reviews.apache.org/r/37034/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.852s]
[INFO] Lens .............................................. SUCCESS [3.197s]
[INFO] Lens API .......................................... SUCCESS [22.644s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.762s]
[INFO] Lens Cube ......................................... SUCCESS [6:05.151s]
[INFO] Lens DB storage ................................... SUCCESS [18.650s]
[INFO] Lens Query Library ................................ SUCCESS [13.984s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.444s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.051s]
[INFO] Lens Server ....................................... SUCCESS [5:38.028s]
[INFO] Lens client ....................................... SUCCESS [33.822s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.843s]
[INFO] Lens Examples ..................................... SUCCESS [8.476s]
[INFO] Lens Distribution ................................. SUCCESS [8.053s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.538s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.673s]
[INFO] Lens Regression ................................... SUCCESS [11.171s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:24.173s
[INFO] Finished at: Mon Aug 03 10:57:35 UTC 2015
[INFO] Final Memory: 170M/1128M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37034: LENS-709: Remove code which is only present
for java6 compatibility
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37034/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 4:32 p.m.)
Review request for lens.
Bugs: LENS-709
https://issues.apache.org/jira/browse/LENS-709
Repository: lens
Description
-------
Diffs (updated)
-----
lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java 5938f8a2666956a6cb278399710df9a820d7f755
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java ff046c7af3239dc82535bedb8f0f545189089db5
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java ac2957dae3a003dcbff78b5e421b0e613dbb4447
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069ed7d7f14f74f6c588bd33c2e542929fce
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2b3f7e3f8406cd4f3833d7499aa573a56f8e60d6
lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java cb226d5814c9dfead7668f7b93ea0804e97985d8
lens-server/src/main/java/org/apache/lens/server/LensServer.java 0da37ad944c426dcce046bd5443428e7b4438c39
lens-server/src/main/java/org/apache/lens/server/LensServices.java c4a61c845a319bbb7ec7e21513ed1fefdf047be8
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7ef804624711e89ef981b83a6576cbc9dc00fb0
lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java e430324f74335a97346ba63ad9d6f6297fc4efc7
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java e0043187aa6d9e6ec5eee0d1200c6a8b587113aa
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java a7c0669c7a1764146df4201c5283ed3cbd426d12
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java fce9cf57413600918952ddb2f13d885af408efe9
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 2295248b13138ec50e8012fcf9b947127488114d
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 79ebe28104115c1da400babcc17df3ceed468069
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java ab5be32960389b65445a724c7507a2c026c9ddf1
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 63d7b9c30b88220ffc04c0d5ccf1c402def2c134
lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java a23399891cb48bd0a19089474aab77584acf2b65
lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 81ad260d0c8ac5f54c4f2cf0bcf7dd81617006b1
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 41444160b5e3184b83a0acce92abbc30c5ebb02f
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 3f4d04a993f18e9d67777126236e03ea4fa7b7b4
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java da3bfd13093de03380cb07c104dbbd006a121498
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java ed2552c8df6329b4ec5c49066e41f00644ef024d
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 01db2626ec9a36eb454b3c0543f8f5fff2bd9b90
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 2beb3b9f1244f0694341f8f37c3d5173ca2f0502
lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4c8a583708b0cbfbbbf4cbe207d1711d9af3045b
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 4a88055f56c95eb4cfabc8f59fd5047dc561fd21
lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java af14fd6620376cc0e16103ec4eb7f650ab40c092
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5edbd134e1978becc103a228a90e883de1bb0d30
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 1747d0302a4d831271964f2229b33ca445783b3b
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java bdd49f5e733b4abdab0a5d66d7dc00661fa08a4d
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java deb7642447cf2dc89a8cdac1d11dc333e9da5c9e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 84b315ce408eaba892118e29f5c4f4103410575d
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java c17b28bd29112f9af054dcc478d069f71ba396b2
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java 52402a0b0a89dbb1d1d22fa5c04ed185c97d1166
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 5f2cbfd5dde34d894e495d6a3cd4e76739c1b852
Diff: https://reviews.apache.org/r/37034/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.852s]
[INFO] Lens .............................................. SUCCESS [3.197s]
[INFO] Lens API .......................................... SUCCESS [22.644s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.762s]
[INFO] Lens Cube ......................................... SUCCESS [6:05.151s]
[INFO] Lens DB storage ................................... SUCCESS [18.650s]
[INFO] Lens Query Library ................................ SUCCESS [13.984s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.444s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.051s]
[INFO] Lens Server ....................................... SUCCESS [5:38.028s]
[INFO] Lens client ....................................... SUCCESS [33.822s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.843s]
[INFO] Lens Examples ..................................... SUCCESS [8.476s]
[INFO] Lens Distribution ................................. SUCCESS [8.053s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.538s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.673s]
[INFO] Lens Regression ................................... SUCCESS [11.171s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:24.173s
[INFO] Finished at: Mon Aug 03 10:57:35 UTC 2015
[INFO] Final Memory: 170M/1128M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 37034: LENS-709: Remove code which is only present
for java6 compatibility
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37034/#review94183
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 3, 2015, 12:49 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37034/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2015, 12:49 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-709
> https://issues.apache.org/jira/browse/LENS-709
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-ml-lib/src/main/java/org/apache/lens/ml/impl/LensMLImpl.java 5938f8a2666956a6cb278399710df9a820d7f755
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceImpl.java ff046c7af3239dc82535bedb8f0f545189089db5
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java ac2957dae3a003dcbff78b5e421b0e613dbb4447
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069ed7d7f14f74f6c588bd33c2e542929fce
> lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2b3f7e3f8406cd4f3833d7499aa573a56f8e60d6
> lens-server/src/main/java/org/apache/lens/server/LensRequestListener.java cb226d5814c9dfead7668f7b93ea0804e97985d8
> lens-server/src/main/java/org/apache/lens/server/LensServer.java 0da37ad944c426dcce046bd5443428e7b4438c39
> lens-server/src/main/java/org/apache/lens/server/LensServices.java c4a61c845a319bbb7ec7e21513ed1fefdf047be8
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7ef804624711e89ef981b83a6576cbc9dc00fb0
> lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java e430324f74335a97346ba63ad9d6f6297fc4efc7
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java e0043187aa6d9e6ec5eee0d1200c6a8b587113aa
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java fce9cf57413600918952ddb2f13d885af408efe9
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 2295248b13138ec50e8012fcf9b947127488114d
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 79ebe28104115c1da400babcc17df3ceed468069
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java ab5be32960389b65445a724c7507a2c026c9ddf1
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 63d7b9c30b88220ffc04c0d5ccf1c402def2c134
> lens-server/src/main/java/org/apache/lens/server/stats/StatisticsService.java a23399891cb48bd0a19089474aab77584acf2b65
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/LogStatisticsStore.java 81ad260d0c8ac5f54c4f2cf0bcf7dd81617006b1
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 41444160b5e3184b83a0acce92abbc30c5ebb02f
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 3f4d04a993f18e9d67777126236e03ea4fa7b7b4
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java da3bfd13093de03380cb07c104dbbd006a121498
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java ed2552c8df6329b4ec5c49066e41f00644ef024d
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 01db2626ec9a36eb454b3c0543f8f5fff2bd9b90
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 2beb3b9f1244f0694341f8f37c3d5173ca2f0502
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java 4c8a583708b0cbfbbbf4cbe207d1711d9af3045b
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java b5235ad5a799cb54c27bb2449478c4e9ef593bc0
> lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java af14fd6620376cc0e16103ec4eb7f650ab40c092
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 5edbd134e1978becc103a228a90e883de1bb0d30
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 1747d0302a4d831271964f2229b33ca445783b3b
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java bdd49f5e733b4abdab0a5d66d7dc00661fa08a4d
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java f1461bc2bd2c89836c26fd3445988009b25c6b18
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 4b9962a9cda22002cdc4826ebce3db4c77216223
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java c17b28bd29112f9af054dcc478d069f71ba396b2
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java 52402a0b0a89dbb1d1d22fa5c04ed185c97d1166
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java 5f2cbfd5dde34d894e495d6a3cd4e76739c1b852
>
> Diff: https://reviews.apache.org/r/37034/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.852s]
> [INFO] Lens .............................................. SUCCESS [3.197s]
> [INFO] Lens API .......................................... SUCCESS [22.644s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.762s]
> [INFO] Lens Cube ......................................... SUCCESS [6:05.151s]
> [INFO] Lens DB storage ................................... SUCCESS [18.650s]
> [INFO] Lens Query Library ................................ SUCCESS [13.984s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:47.444s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.051s]
> [INFO] Lens Server ....................................... SUCCESS [5:38.028s]
> [INFO] Lens client ....................................... SUCCESS [33.822s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.843s]
> [INFO] Lens Examples ..................................... SUCCESS [8.476s]
> [INFO] Lens Distribution ................................. SUCCESS [8.053s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.538s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.673s]
> [INFO] Lens Regression ................................... SUCCESS [11.171s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:24.173s
> [INFO] Finished at: Mon Aug 03 10:57:35 UTC 2015
> [INFO] Final Memory: 170M/1128M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>