[GitHub] [nifi] mattyb149 removed a comment on issue #3341: NIFI-6082: Added DatabaseRecordLookupService, refactored common DB utils

[GitBox <gi...@apache.org>]

mattyb149 removed a comment on issue #3341: NIFI-6082: Added DatabaseRecordLookupService, refactored common DB utils
URL: https://github.com/apache/nifi/pull/3341#issuecomment-472058906
 
 
   When I removed the code from `DataTypeUtils.convertRecordFieldtoObject()`, I get the same `IllegalTypeConversionException` thrown from JoltTransformRecord as before this PR. Its `transform()` method calls convertRecordFieldtoObject() directly (not via `DataTypeUtils.toRecord() or whatever), and only if the object is a Record does it check the fields' types and convert each of the fields. Once it gets called with a Map of ARRAY[RECORD], then it calls `convertRecordMapToJavaMap()` which then calls convertRecordFieldtoObject() for each field. The field in my example is an Object[] with a type of ARRAY[RECORD]. There is no handling for Object[] at that point, hence the IllegalTypeConversionException. Were you not seeing this during your testing?
   
   I think I should put that code back in, as well as tracking down why I had to put that "override nullable" stuff in. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services