You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/02 13:27:53 UTC
[GitHub] zentol commented on a change in pull request #6786:
[FLINK-10292][rest] Separate REST and Dispatcher RPC thread pools
zentol commented on a change in pull request #6786: [FLINK-10292][rest] Separate REST and Dispatcher RPC thread pools
URL: https://github.com/apache/flink/pull/6786#discussion_r221949410
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
##########
@@ -180,7 +183,7 @@ public WebMonitorEndpoint(
this.restConfiguration = Preconditions.checkNotNull(restConfiguration);
this.resourceManagerRetriever = Preconditions.checkNotNull(resourceManagerRetriever);
this.transientBlobService = Preconditions.checkNotNull(transientBlobService);
- this.executor = Preconditions.checkNotNull(executor);
+ this.executor = Executors.newFixedThreadPool(endpointConfiguration.getNumThreads(), new ExecutorThreadFactory("Flink-" + getClass().getSimpleName()));
Review comment:
Who would then be responsible for shutting it down?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services