[jira] [Commented] (ZOOKEEPER-1993) Keep the client port upon parsing config

["Alexander Shraer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077913#comment-14077913 ] 

Alexander Shraer commented on ZOOKEEPER-1993:
---------------------------------------------

I don't think #3 should be part of this JIRA - its not related to client port, so probably should be discussed separately. 

For #2 - why is this a good idea ? If you start off by having a client port in both, you clearly made a mistake so your server shouldn't come up. If you start with just the static one and then a reconfiguration adds a port for your server to the dynamic config then the static one should be removed, I thought that this is what you were proposing. 

> Keep the client port upon parsing config
> ----------------------------------------
>
>                 Key: ZOOKEEPER-1993
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1993
>             Project: ZooKeeper
>          Issue Type: Sub-task
>    Affects Versions: 3.5.0
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>            Priority: Blocker
>             Fix For: 3.5.0
>
>
> 1. Current implementation ignored and removed "clientPort" on parsing. For the sake of backward compatibility, "clientPort" should be kept and used upon parsing config on fresh boot.
> 2. When getting clientPort from both the old config and dynamic file, the one in dynamic file is of higher priority.
> 3. When "dynamicConfigFile" is set in zoo.cfg, standalone mode will be disabled.



--
This message was sent by Atlassian JIRA
(v6.2#6252)