[GitHub] [spark] nonsleepr commented on a change in pull request #26000: [SPARK-29330][CORE][YARN] Allow users to chose the name of Spark Shuffle service

[GitBox <gi...@apache.org>]

nonsleepr commented on a change in pull request #26000: [SPARK-29330][CORE][YARN] Allow users to chose the name of Spark Shuffle service
URL: https://github.com/apache/spark/pull/26000#discussion_r330751020
 
 

 ##########
 File path: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
 ##########
 @@ -136,7 +136,11 @@
   private DB db;
 
   public YarnShuffleService() {
-    super("spark_shuffle");
+    this("spark_shuffle");
+  }
+
+  public YarnShuffleService(String serviceName) {
 
 Review comment:
   This is mostly to be able to test it since `yarn.nodemanager.aux-services.spark_shuffle.class` option assumes no-args constructor. Maybe make it `protected`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org