You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/01/30 11:37:49 UTC

Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56075/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.


Bugs: AMBARI-19765
    https://issues.apache.org/jira/browse/AMBARI-19765


Repository: ambari


Description
-------

UI changes


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 753b7f7 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4fe6f43 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 

Diff: https://reviews.apache.org/r/56075/diff/


Testing
-------

manually tested.


Thanks,

Pallav Kulshreshtha


Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56075/#review163637
-----------------------------------------------------------


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 30, 2017, 11:47 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56075/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2017, 11:47 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19765
>     https://issues.apache.org/jira/browse/AMBARI-19765
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI changes
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 753b7f7 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4fe6f43 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56075/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56075/#review163630
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Jan. 30, 2017, 11:47 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56075/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2017, 11:47 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19765
>     https://issues.apache.org/jira/browse/AMBARI-19765
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI changes
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 753b7f7 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4fe6f43 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 
> 
> Diff: https://reviews.apache.org/r/56075/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56075/
-----------------------------------------------------------

(Updated Jan. 30, 2017, 11:47 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.


Bugs: AMBARI-19765
    https://issues.apache.org/jira/browse/AMBARI-19765


Repository: ambari


Description
-------

UI changes


Diffs (updated)
-----

  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 6a77633 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 753b7f7 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5db22d0 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 17abb65 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4fe6f43 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 

Diff: https://reviews.apache.org/r/56075/diff/


Testing
-------

manually tested.


Thanks,

Pallav Kulshreshtha