You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/03/02 07:01:00 UTC
[jira] [Commented] (IMPALA-11478) Cleanup JniCatalog
[ https://issues.apache.org/jira/browse/IMPALA-11478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695504#comment-17695504 ]
ASF subversion and git services commented on IMPALA-11478:
----------------------------------------------------------
Commit eaf71bca0a3538056765dbbce13c0f503045b38b in impala's branch refs/heads/master from Peter Rozsa
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=eaf71bca0 ]
IMPALA-11948: Remove operation logging from getCatalogServerMetrics
IMPALA-11478 added operation-level logging to every catalog method in
JniCatalog, but getCatalogServerMetrics operation is called many times
by catalogd itself. Start and finish logs for this operation are useless,
therefore only the warnings about size and elapsed time should remain.
Tests:
- manually validated that warning-level logs are still generated
- manually validated that start/finish log entries are not generated
Change-Id: Ifd01e9f42ccc6a4adce41caf8884ea3c2c781452
Reviewed-on: http://gerrit.cloudera.org:8080/19557
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Cleanup JniCatalog
> ------------------
>
> Key: IMPALA-11478
> URL: https://issues.apache.org/jira/browse/IMPALA-11478
> Project: IMPALA
> Issue Type: Task
> Components: Frontend
> Reporter: Quanlong Huang
> Assignee: Peter Rozsa
> Priority: Major
> Labels: newbie, ramp-up
> Fix For: Impala 4.3.0
>
>
> There are some dead codes in JniCatalog. E.g. getDbs, getTableNames, getFunctions are not used by coordinator. Instead, coordinator uses its own methods in JniFrontend. So these methods can be removed.
> [https://github.com/apache/impala/blob/29a26a536c004e4d16fdb56e1bb5a41605ae4e30/fe/src/main/java/org/apache/impala/service/JniCatalog.java#L272-L311]
> [https://github.com/apache/impala/blob/29a26a536c004e4d16fdb56e1bb5a41605ae4e30/fe/src/main/java/org/apache/impala/service/JniCatalog.java#L366-L391]
> On the other side, the other RPC code paths in JniCatalog need some simplification (after IMPALA-11401) since they are similar. Mostly using a try-catch clause to wrap the internal call with thread annotation and error handling, and log some message about start/finish the RPC. As [~csringhofer] mentioned in the code review of [https://gerrit.cloudera.org/c/18772/5/fe/src/main/java/org/apache/impala/service/JniCatalog.java#227], it could also make sense to create a class hierarchy like CatalogJniOp with the basic common skeleton of these functions
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org