You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2011/03/21 23:27:05 UTC
[jira] [Created] (HADOOP-7204) remove local unused fs variable from
CmdHandler and FsShellPermissions.changePermissions
remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
----------------------------------------------------------------------------------------
Key: HADOOP-7204
URL: https://issues.apache.org/jira/browse/HADOOP-7204
Project: Hadoop Common
Issue Type: Bug
Reporter: Boris Shkolnik
Assignee: Boris Shkolnik
Priority: Minor
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7204) remove local unused fs variable from
CmdHandler and FsShellPermissions.changePermissions
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-7204:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
committed to trunk
> remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-7204
> URL: https://issues.apache.org/jira/browse/HADOOP-7204
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-7204.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7204) remove local unused fs variable
from CmdHandler and FsShellPermissions.changePermissions
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13012171#comment-13012171 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7204:
------------------------------------------------
Seems that this caused the recent failure of {{TestHDFSCLI}} (e.g. [build #293|https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/293//testReport/org.apache.hadoop.cli/TestHDFSCLI/testAll/]). Could you take a look?
> remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-7204
> URL: https://issues.apache.org/jira/browse/HADOOP-7204
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-7204.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7204) remove local unused fs variable
from CmdHandler and FsShellPermissions.changePermissions
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009770#comment-13009770 ]
Boris Shkolnik commented on HADOOP-7204:
----------------------------------------
compiled hdfs and mr with the change(jar-test). All compiled.
> remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-7204
> URL: https://issues.apache.org/jira/browse/HADOOP-7204
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-7204.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7204) remove local unused fs variable from
CmdHandler and FsShellPermissions.changePermissions
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-7204:
-----------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-7204
> URL: https://issues.apache.org/jira/browse/HADOOP-7204
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-7204.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7204) remove local unused fs variable
from CmdHandler and FsShellPermissions.changePermissions
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009754#comment-13009754 ]
Jitendra Nath Pandey commented on HADOOP-7204:
----------------------------------------------
Patch looks good to me. +1
None of the changed methods are public, however it would be good to compile Hdfs and map-reduce with this change, just to make sure.
> remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-7204
> URL: https://issues.apache.org/jira/browse/HADOOP-7204
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-7204.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7204) remove local unused fs variable
from CmdHandler and FsShellPermissions.changePermissions
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009921#comment-13009921 ]
Hudson commented on HADOOP-7204:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #532 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/532/])
HADOOP-7204. remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-7204
> URL: https://issues.apache.org/jira/browse/HADOOP-7204
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-7204.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7204) remove local unused fs variable
from CmdHandler and FsShellPermissions.changePermissions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009876#comment-13009876 ]
Hadoop QA commented on HADOOP-7204:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12474243/HADOOP-7204.patch
against trunk revision 1083957.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/316//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/316//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/316//console
This message is automatically generated.
> remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-7204
> URL: https://issues.apache.org/jira/browse/HADOOP-7204
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-7204.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7204) remove local unused fs variable from
CmdHandler and FsShellPermissions.changePermissions
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-7204:
-----------------------------------
Attachment: HADOOP-7204.patch
> remove local unused fs variable from CmdHandler and FsShellPermissions.changePermissions
> ----------------------------------------------------------------------------------------
>
> Key: HADOOP-7204
> URL: https://issues.apache.org/jira/browse/HADOOP-7204
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Priority: Minor
> Attachments: HADOOP-7204.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira