You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/22 07:56:15 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3513: [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
Alonexc opened a new issue, #3513:
URL: https://github.com/apache/incubator-eventmesh/issues/3513
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-storage/eventmesh-storage-pravega/src/test/java/org/apache/eventmesh/storage/pravega/config/PravegaStorageConfigTest.java line 50,51,53,54,56-58
analysis and explanation:
The standard assertions library methods such as org.junit.Assert.assertEquals, and org.junit.Assert.assertSame expect the first argument to be the expected value and the second argument to be the actual value. For AssertJ, it’s the other way around, the argument of org.assertj.core.api.Assertions.assertThat is the actual value, and the subsequent calls contain the expected values. Swap them, and your test will still have the same outcome (succeed/fail when it should) but the error messages will be confusing.
### Describe the solution you'd like
Swap actual and expected values.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on issue #3513: [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3513:
URL: https://github.com/apache/eventmesh/issues/3513#issuecomment-1501299854
@akashsawan1 Welcome, you can submit a pr first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 commented on issue #3513: [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 commented on issue #3513:
URL: https://github.com/apache/eventmesh/issues/3513#issuecomment-1501879396
I have already submitted a PR 2 days back.
Please check and let me know if any change is required.
https://github.com/apache/eventmesh/pull/3658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 closed issue #3513: [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 closed issue #3513: [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
URL: https://github.com/apache/eventmesh/issues/3513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 commented on issue #3513: [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 commented on issue #3513:
URL: https://github.com/apache/eventmesh/issues/3513#issuecomment-1503896231
hey, I have made the required changes that you suggested.
https://github.com/apache/eventmesh/pull/3697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 commented on issue #3513: [Enhancement] Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest]
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 commented on issue #3513:
URL: https://github.com/apache/eventmesh/issues/3513#issuecomment-1500169585
I would like to work on this.
/assign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org