[jira] [Commented] (HBASE-5770) Add a clock skew warning threshold

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252235#comment-13252235 ] 

Hadoop QA commented on HBASE-5770:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522360/HBASE_5770_v1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//console

This message is automatically generated.
                
> Add a clock skew warning threshold
> ----------------------------------
>
>                 Key: HBASE-5770
>                 URL: https://issues.apache.org/jira/browse/HBASE-5770
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, regionserver
>            Reporter: Ian Varley
>            Assignee: Ian Varley
>            Priority: Minor
>         Attachments: HBASE_5770_v1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There's currently an exception thrown by the master when a region server attempts to start up with clock skew greater than some configured amount (defaulting to 30 seconds). However, it'd be nice to get some warnings logged at a value that isn't severe enough to warrant killing the RS, but still represents significant skew that could affect correctness. Will attach a simple patch to add this as a setting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira