You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "qianye1001 (via GitHub)" <gi...@apache.org> on 2024/08/13 06:19:44 UTC

[PR] [ISSUE #8517] client send UNREGISTER_CLIENT request twice may cause proxy NPE [rocketmq]

qianye1001 opened a new pull request, #8528:
URL: https://github.com/apache/rocketmq/pull/8528

   <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
   
   Fixes #8517
   
   ### Brief Description
   client send UNREGISTER_CLIENT request twice may cause proxy NPE
   check channel is null before use it, if channel is null, log warn instead of NPE
   <!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
   
   ### How Did You Test This Change?
   
   <!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #8517] client send UNREGISTER_CLIENT request twice may cause proxy NPE [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8528:
URL: https://github.com/apache/rocketmq/pull/8528#issuecomment-2285466605

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8528?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `0%` with `16 lines` in your changes missing coverage. Please review.
   > Project coverage is 46.86%. Comparing base [(`fa0cd49`)](https://app.codecov.io/gh/apache/rocketmq/commit/fa0cd49df20223269fa659f940539b40064359a3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b3f7df8`)](https://app.codecov.io/gh/apache/rocketmq/commit/b3f7df8e280011c38a3f91cba4add80336b44e2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/8528?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...proxy/remoting/activity/ClientManagerActivity.java](https://app.codecov.io/gh/apache/rocketmq/pull/8528?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fremoting%2Factivity%2FClientManagerActivity.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3JlbW90aW5nL2FjdGl2aXR5L0NsaWVudE1hbmFnZXJBY3Rpdml0eS5qYXZh) | 0.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/8528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #8528      +/-   ##
   =============================================
   - Coverage      46.95%   46.86%   -0.09%     
   + Complexity     11325    11296      -29     
   =============================================
     Files           1275     1275              
     Lines          89061    89067       +6     
     Branches       11454    11456       +2     
   =============================================
   - Hits           41815    41739      -76     
   - Misses         42081    42155      +74     
   - Partials        5165     5173       +8     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/8528?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #8517] Fix client send UNREGISTER_CLIENT request twice may cause proxy NPE [rocketmq]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #8528:
URL: https://github.com/apache/rocketmq/pull/8528


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org