You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/09/26 19:06:13 UTC
[kudu-CR] WIP: Support non-voter in leader election
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8142
to review the following change.
Change subject: WIP: Support non-voter in leader election
......................................................................
WIP: Support non-voter in leader election
This still isn't sufficient. Apparently the consensus queue gets
confused, still.
Change-Id: I545c8a7d3d83c4a95769edd70487420c60c09d15
---
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/leader_election.h
M src/kudu/consensus/quorum_util.cc
3 files changed, 7 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/8142/1
--
To view, visit http://gerrit.cloudera.org:8080/8142
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I545c8a7d3d83c4a95769edd70487420c60c09d15
Gerrit-Change-Number: 8142
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] WIP: Support non-voter in leader election
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/8142 )
Change subject: WIP: Support non-voter in leader election
......................................................................
Abandoned
ok, marking this one abandoned
--
To view, visit http://gerrit.cloudera.org:8080/8142
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I545c8a7d3d83c4a95769edd70487420c60c09d15
Gerrit-Change-Number: 8142
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] WIP: Support non-voter in leader election
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8142 )
Change subject: WIP: Support non-voter in leader election
......................................................................
Patch Set 1:
> Does this need to get merged into Alexey's patch?
Yep. Actually, I already integrated it into my patch locally. Will post update on https://gerrit.cloudera.org/#/c/8138/ today.
--
To view, visit http://gerrit.cloudera.org:8080/8142
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I545c8a7d3d83c4a95769edd70487420c60c09d15
Gerrit-Change-Number: 8142
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2017 17:11:16 +0000
Gerrit-HasComments: No
[kudu-CR] WIP: Support non-voter in leader election
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8142 )
Change subject: WIP: Support non-voter in leader election
......................................................................
Patch Set 1:
Does this need to get merged into Alexey's patch?
--
To view, visit http://gerrit.cloudera.org:8080/8142
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I545c8a7d3d83c4a95769edd70487420c60c09d15
Gerrit-Change-Number: 8142
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 27 Sep 2017 14:59:44 +0000
Gerrit-HasComments: No
[kudu-CR] WIP: Support non-voter in leader election
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8142 )
Change subject: WIP: Support non-voter in leader election
......................................................................
Patch Set 1:
Thank you for digging this up. I can take over this patch, if necessary.
--
To view, visit http://gerrit.cloudera.org:8080/8142
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I545c8a7d3d83c4a95769edd70487420c60c09d15
Gerrit-Change-Number: 8142
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 26 Sep 2017 19:12:05 +0000
Gerrit-HasComments: No