You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Stefan Egli (JIRA)" <ji...@apache.org> on 2015/08/25 18:26:45 UTC

[jira] [Commented] (OAK-3250) Restart DocumentNodeStore on lease timeout instead of System.exit

    [ https://issues.apache.org/jira/browse/OAK-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711566#comment-14711566 ] 

Stefan Egli commented on OAK-3250:
----------------------------------

bq. marking the local instance as 'deactivating'
that part won't work: it assumes that the upper layer (namely discovery.oak) takes note of this 'intermediate deactivating' state - since once the restart has finished, the local node would again be 'active' - if discovery.oak would 'miss' this intermediate state, it would not know that a restart has happened.

I see the following alternatives:
* either change the clusterId of the local instance as part of the restart: this way, anyone reading the discovery-lite descriptor will know that a restart has happened (since the local clusterId changed)
* or introduce a 'repository start time': upon restart this would be reset and upper layers would also be able to notice a restart (by keeping track of the original repository-start-time

> Restart DocumentNodeStore on lease timeout instead of System.exit
> -----------------------------------------------------------------
>
>                 Key: OAK-3250
>                 URL: https://issues.apache.org/jira/browse/OAK-3250
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.4
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>             Fix For: 1.3.5
>
>
> As discussed [on the list|http://markmail.org/thread/uo6n5oozlbhe7ifg] usage of System.exit is not ideal and one suggested alternative is to follow up on the idea to instead perform a 'restart of DocumentNodeStore' - while marking the local instance as 'deactivating' towards discovery-lite-descriptor so that upper layer discovery.oak can properly send a TOPOLOGY_CHANGING to all listeners, so that they immediately stop any topology-dependent activity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)