You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/04/18 23:20:14 UTC

Review Request 20501: Caputre all Hive properties in the stack definition

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml fa05920 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 16ca4c1 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review40823
-----------------------------------------------------------


Imho, I do not know if the password should be put into the default stack definition. The user sees the passwords as '****' not knowing its true value. The blueprint XML is the one who should have the default password. Other configs I can understand having a default value.

- Srimanth Gunturi


On April 18, 2014, 9:32 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 9:32 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 16ca4c1 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review41601
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
<https://reviews.apache.org/r/20501/#comment75128>

    Missing param and return descriptions



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment75129>

    missing description


- John Speidel


On April 25, 2014, 11:26 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 11:26 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 90017ac 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
>  mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.966s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [9.690s]
> [INFO] Ambari Views ...................................... SUCCESS [1.835s]
> [INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.533s]
> [INFO] Ambari Client ..................................... SUCCESS [0.522s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.

> On April 30, 2014, 3:33 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java, line 98
> > <https://reviews.apache.org/r/20501/diff/8/?file=571133#file571133line98>
> >
> >     should hashCode and equals be updated for new fields?

Since the new fields are not identity fields, did not include them in equals and hashcode. These methods already use name + value.


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review41836
-----------------------------------------------------------


On April 30, 2014, 4:41 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 4:41 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 2ca70f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
>  mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.966s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [9.690s]
> [INFO] Ambari Views ...................................... SUCCESS [1.835s]
> [INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.533s]
> [INFO] Ambari Client ..................................... SUCCESS [0.522s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review41836
-----------------------------------------------------------


Sid, required property validation in BlueprintResourceProvider is still wrong.  At this point I would really like to have the changes in BlueprintResourceProvider split out into another patch so that we can get the base stack changes submitted.


ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
<https://reviews.apache.org/r/20501/#comment75457>

    missing return desription



ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
<https://reviews.apache.org/r/20501/#comment75458>

    should be 'isRequired()'



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment75460>

    javadoc should state that method throws IllegalArgumentException if validation fails.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment75464>

    validation is still incorrect.  If there are host group scoped configurations, validation needs to be done at the host group level by overlaying the host group configuration over cluster scoped configurations.  Each host group may contain a different set of configuration properties and these are specific to the containing host group.  



ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
<https://reviews.apache.org/r/20501/#comment75465>

    should hashCode and equals be updated for new fields?



ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
<https://reviews.apache.org/r/20501/#comment75466>

    what is the default property type?  Every property should now have a type even if it is a standard property type.  For all standard properties, the default property type should be used without need of specifying the type in the stack definition.


- John Speidel


On April 29, 2014, 9:41 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 9:41 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 2ca70f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
>  mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.966s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [9.690s]
> [INFO] Ambari Views ...................................... SUCCESS [1.835s]
> [INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.533s]
> [INFO] Ambari Client ..................................... SUCCESS [0.522s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review41881
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
<https://reviews.apache.org/r/20501/#comment75542>

    This change is unnecessary after removing BlueprintResourceProvider(see other comment).



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment75540>

    Please remove this file from that patch since all of the new functionality has been removed from the class.



ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
<https://reviews.apache.org/r/20501/#comment75541>

    Not a big deal but it would have been cleaner to just initialize type to DEFAULT instead of requiring an if condition here.


- John Speidel


On April 30, 2014, 4:41 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 4:41 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 2ca70f5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
>  mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.966s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [9.690s]
> [INFO] Ambari Views ...................................... SUCCESS [1.835s]
> [INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.533s]
> [INFO] Ambari Client ..................................... SUCCESS [0.522s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review41898
-----------------------------------------------------------

Ship it!


You should also remove BlueprintResourceProviderTest and AmbariServer from the patch.

- John Speidel


On May 1, 2014, 12:17 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 12:17 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 7771b73 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
>  mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.966s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [9.690s]
> [INFO] Ambari Views ...................................... SUCCESS [1.835s]
> [INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.533s]
> [INFO] Ambari Client ..................................... SUCCESS [0.522s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated May 1, 2014, 12:17 a.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Changes
-------

Removed ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java, from the patch.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 7771b73 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated May 1, 2014, 12:04 a.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Changes
-------

- Incorporated comments.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 7771b73 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 30, 2014, 4:41 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Changes
-------

- Incorporated comments.
- Striped of validation code from BlueprintResourceProvider.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 2ca70f5 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 29, 2014, 9:41 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Changes
-------

- New patch addresses all open issues.
- Validate Configurations parses both cluster scoped and host group configs into a single set.
- Patch mandates required properties to be present in the blueprint.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 2ca70f5 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 25, 2014, 11:26 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 90017ac 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 25, 2014, 11:21 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Changes
-------

- Incorporated comments.
- Removed replace of password properties with magic value.
- Added unit test for blueprint validation.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 90017ac 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.

> On April 25, 2014, 4:29 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java, line 632
> > <https://reviews.apache.org/r/20501/diff/5/?file=566189#file566189line632>
> >
> >     Incomplete javadoc

Private method, no javadocs available elsewhere.


> On April 25, 2014, 4:29 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java, line 423
> > <https://reviews.apache.org/r/20501/diff/5/?file=566192#file566192line423>
> >
> >     This is only looking at cluster scoped configuration and is ignoring host group scoped configuration.  Validation needs to be done on the complete configuration.

Moved validation to the method which formulates Create Command and look at the properties provided by the user.
For passwords the validateConfiguration should allow properties to be skipped if universal password property exists.


> On April 25, 2014, 4:29 p.m., John Speidel wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml, line 48
> > <https://reviews.apache.org/r/20501/diff/5/?file=566198#file566198line48>
> >
> >     why is this a space ' ' and not null ''?

No changes here, reverted to as it was. No impact to UI.


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review41474
-----------------------------------------------------------


On April 25, 2014, 11:26 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 11:26 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 5fef43a 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 91632c0 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 90017ac 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 40e4bf3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
>  mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.966s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [9.690s]
> [INFO] Ambari Views ...................................... SUCCESS [1.835s]
> [INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.533s]
> [INFO] Ambari Client ..................................... SUCCESS [0.522s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/#review41474
-----------------------------------------------------------


In my opinion, this patch should probably be split into 2 distinct patches.  One for the base stack related changes for the new require-input functionality and another patch for the blueprint code that uses this new functionality. 


ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
<https://reviews.apache.org/r/20501/#comment74903>

    missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
<https://reviews.apache.org/r/20501/#comment74902>

    Incomplete javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
<https://reviews.apache.org/r/20501/#comment74904>

    missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
<https://reviews.apache.org/r/20501/#comment74905>

    incomplete javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
<https://reviews.apache.org/r/20501/#comment74906>

    incomplete javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
<https://reviews.apache.org/r/20501/#comment74907>

    missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
<https://reviews.apache.org/r/20501/#comment74908>

    missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
<https://reviews.apache.org/r/20501/#comment74909>

    missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74910>

    should expand imports



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74911>

    missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74912>

    missing ambariMetaInfo param in javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74916>

    remove throws clause.  See comment in validateConfigurations()



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74917>

    remove throws clause.  See comment in validateConfigurations()



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74918>

    remove throws clause.  See comment in validateConfigurations()



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74913>

    This method is called for both create and delete operations.  For delete, we should not test for required properties.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74919>

    missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74914>

    This is only looking at cluster scoped configuration and is ignoring host group scoped configuration.  Validation needs to be done on the complete configuration.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74915>

    Shouldn't throw the generic AmbariException here as it will result in a 500 system exception back to the user instead of the expected 400 bad request.  For now throw an InvalidArgumentException (not exactly correct since it is really a missing argument) which will result in a 400 back to the user.  



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74920>

    expand imports



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74921>

    missing javadoc



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
<https://reviews.apache.org/r/20501/#comment74922>

    It was decided that we would not use the approach of a using the lowercase service name as a default property.  Instead, we will introduce a new universal_password field in the cluster create call.



ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml
<https://reviews.apache.org/r/20501/#comment74923>

    why is this line needed?



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml
<https://reviews.apache.org/r/20501/#comment74924>

    why is this a space ' ' and not null ''?



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml
<https://reviews.apache.org/r/20501/#comment74925>

    why is this line needed?  Isn't require-input an attribute of the property tag?



ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
<https://reviews.apache.org/r/20501/#comment74926>

    why do we have a default password value specified here?  Why isn't this property marked as require-input?


- John Speidel


On April 23, 2014, 9:47 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20501/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 9:47 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-5515
>     https://issues.apache.org/jira/browse/AMBARI-5515
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
>  Hive deployment via Blueprints works when the following configurations were added to the blueprint.
> Several of the properties do exist in the stack definition, but most don't.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e 
>   ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 
> 
> Diff: https://reviews.apache.org/r/20501/diff/
> 
> 
> Testing
> -------
> 
>  mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.966s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
> [INFO] Ambari Web ........................................ SUCCESS [9.690s]
> [INFO] Ambari Views ...................................... SUCCESS [1.835s]
> [INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.533s]
> [INFO] Ambari Client ..................................... SUCCESS [0.522s]
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 23, 2014, 9:47 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 23, 2014, 6:44 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Changes
-------

- Reverted changes made to add default passwords in the stack.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 23, 2014, 6:33 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Changes
-------

- New patch without any unit tests, need some feedback on the approach.
- The stack definition will mark properties as being required, if blueprint definition does not have these properties, we error out on Blueprint creation.
- Passwords are special properties since we need to provide a default is none provided, the type property on a configuration qualifies a password.
- Default password is service in all lowercase.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 659499e 
  ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java 08a545f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 034e877 
  ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java e5cbdf7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java ea2fdec 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java acc5f4a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/configuration/global.xml 61a2b90 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 781fdcb 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 3a63b78 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 9e12c63 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 7d35558 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 18, 2014, 9:50 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 16ca4c1 

Diff: https://reviews.apache.org/r/20501/diff/


Testing (updated)
-------

 mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.966s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.303s]
[INFO] Ambari Web ........................................ SUCCESS [9.690s]
[INFO] Ambari Views ...................................... SUCCESS [1.835s]
[INFO] Ambari Server ..................................... SUCCESS [14:38.002s]
[INFO] Ambari Agent ...................................... SUCCESS [15.533s]
[INFO] Ambari Client ..................................... SUCCESS [0.522s]
[INFO] ------------------------------------------------------------------------


Thanks,

Sid Wagle

Re: Review Request 20501: Caputre all Hive properties in the stack definition

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20501/
-----------------------------------------------------------

(Updated April 18, 2014, 9:32 p.m.)


Review request for Ambari, Jaimin Jetly, John Speidel, Sumit Mohanty, and Srimanth Gunturi.


Bugs: AMBARI-5515
    https://issues.apache.org/jira/browse/AMBARI-5515


Repository: ambari


Description
-------

 Hive deployment via Blueprints works when the following configurations were added to the blueprint.
Several of the properties do exist in the stack definition, but most don't.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java 18031d0 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml f3c274a 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 3a6ed76 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml e164c64 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 6336a70 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 16ca4c1 

Diff: https://reviews.apache.org/r/20501/diff/


Testing
-------


Thanks,

Sid Wagle