[PR] shell: Fix static command registration [mynewt-core]

["kasjer (via GitHub)" <gi...@apache.org>]

kasjer opened a new pull request, #3679:
URL: https://github.com/apache/mynewt-core/pull/3679

   Command registered to module via link table created variable that did not include module
   name. This resulted in name collision if second module tried to make command with same
   name.
   Collision would happen in following case:
   ```c
   SHELL_MODULE_CMD(module1, test, cmd1, NULL);
   SHELL_MODULE_CMD(module2, test, cmd2, NULL);
   ```
   While two modules do have different name, same command name would not build.
   
   Now internal variable that is created has module embedded to prevent collision.
   
   Adjustment in **shell.c** for compat command is applied.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] shell: Fix static command registration [mynewt-core]

["kasjer (via GitHub)" <gi...@apache.org>]

kasjer merged PR #3679:
URL: https://github.com/apache/mynewt-core/pull/3679


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org