[GitHub] [accumulo-examples] ctubbsii commented on a change in pull request #49: Fix #42 Update compactionStrategy example

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #49: Fix #42 Update compactionStrategy example
URL: https://github.com/apache/accumulo-examples/pull/49#discussion_r278738383
 
 

 ##########
 File path: src/main/java/org/apache/accumulo/examples/client/SequentialBatchWriter.java
 ##########
 @@ -52,14 +49,42 @@ public static Value createValue(long rowId) {
     return new Value(value);
   }
 
+  static class Opts extends ClientOpts {
 
 Review comment:
   As an aside (not for this issue... but perhaps in future), I think it'd be fine if the examples stopped using JCommander and just had options hard-coded. As examples, they are intended to be user-editable, so the simpler they are, the better. You can't get much simpler than hard-coded literals at the beginning of "main".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services