[jira] Resolved: (THRIFT-933) Haskell's Thrift.cabal has warnings

["Anthony Molinaro (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anthony Molinaro resolved THRIFT-933.
-------------------------------------

    Resolution: Fixed

Looks good, so I commited it.

> Haskell's Thrift.cabal has warnings
> -----------------------------------
>
>                 Key: THRIFT-933
>                 URL: https://issues.apache.org/jira/browse/THRIFT-933
>             Project: Thrift
>          Issue Type: Bug
>          Components: Haskell - Library
>    Affects Versions: 0.6
>         Environment: Mac OS X 10.6 (x86)
> cabal-install version 0.8.2
> using version 1.8.0.6 of the Cabal library 
>            Reporter: Christian Lavoie
>            Assignee: Christian Lavoie
>             Fix For: 0.6
>
>         Attachments: v1-thrift-fix-cabal-check.patch
>
>
> Turns out cabal has a check system:
> {noformat}
> $ cabal check
> The following warnings are likely affect your build negatively:
> * 'license: Apache2' is not a recognised license. The known licenses are: GPL,
> GPL-2, GPL-3, LGPL, LGPL-2.1, LGPL-3, BSD3, BSD4, MIT, PublicDomain,
> AllRightsReserved, OtherLicense
> These warnings may cause trouble when distributing the package:
> * No 'maintainer' field.
> * No 'description' field.
> * A 'license-file' is not specified.
> The following errors will cause portability problems on other environments:
> * Unfortunately the license 'Apache2' messes up the parser in earlier Cabal
> versions so you need to specify 'cabal-version: >= 1.4'. Alternatively if you
> require compatability with earlier Cabal versions then use 'OtherLicense'.
> * Unfortunately the language extensions 'DeriveDataTypeable',
> 'KindSignatures', 'MagicHash' break the parser in earlier Cabal versions so
> you need to specify 'cabal-version: >= 1.2.3'. Alternatively if you require
> compatability with earlier Cabal versions then you may be able to use an
> equivalent compiler-specific flag.
> * The dependency 'build-depends: base' does not specify an upper bound on the
> version number. Each major release of the 'base' package changes the API in
> various ways and most packages will need some changes to compile with it. The
> recommended practise is to specify an upper bound on the version of the 'base'
> package. This ensures your package will continue to build when a new major
> version of the 'base' package is released. If you are not sure what upper
> bound to use then use the next major version. For example if you have tested
> your package with 'base' version 2 and 3 then use 'build-depends: base >= 2 &&
> < 4'.
> Hackage would reject this package.
> {noformat}
> This patch addresses each and every one of those warnings.
> PLEASE NOTE THE MUCKING AROUND WITH LICENSING.
> It should be a legal no-op, cabal merely prefers this format (and does not recognize the Apache2 license built-in). The new LICENSE file is the Apache2 license stolen from ../../LICENSE, but with the trailing addendums removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.